Uses uuid for auto-generated ids and prepends type #12834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Smalley <[email protected]>
|
Putting together a PR into master to show how much this cleans up. |
|
I figured that we would only need to prefix IDs when we have a user-specified ID, why do we need it otherwise? |
|
Oh, I guess when we receive an ID from the API we don't know if it needs to have the type prepended so if we always prepend the type then we remove a bit of ambiguity. 👍 |
|
Here is the PR into the |
|
@spalger, exactly. This essentially allows us to remove all of the compatibility layer in 6.0 in exchange for creating ID's like this. |
epixa
pushed a commit
to epixa/kibana
that referenced
this pull request
Jul 14, 2017
Signed-off-by: Tyler Smalley <[email protected]>
epixa
added a commit
that referenced
this pull request
Jul 14, 2017
* Uses uuid for auto-generated ids and prepends type (#12834) Signed-off-by: Tyler Smalley <[email protected]> * saved_objects: remove isSingleTypeError reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses self-generated id's when creating documents. This will allow us to create type prepended id's in 6.x, allowing for direct get/update/delete instead of by query.
Without this, we will be forced to do things like this: https://github.com/elastic/kibana/pull/12794/files#diff-cc9fbe8850c8f590da1323a91d29717dR220
Here is some manual testing guidance: #12648 (comment)
Also, ES also now returning
type_missing_exceptionin 5.6 instead of anillegal_argument_exception