Hide welcome page privacy statement on cloud instances

[gsoldevila]

Solves #110638

Updates the welcome page interstitial to show the privacy statement notice if and only if we are not on a cloud instance.

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[sabarasaba]

@elastic/platform-deployment-management changes lgtm

[pgayvallet]

LGTM, just a test NIT

[pgayvallet]

We usually try to avoid using clearAllMocks to avoid cleaning potentially pre-feeded mocks from outside (and overall to properly reconstruct the test's sanbox between every test)

describe('stuff', () => {
   let mockInitializerContext: ReturnType<typeof coreMock.createPluginInitializerContext>;
   let home: ReturnType<typeof homePluginMock.createSetupContract>;
   let screenshotMode: ReturnType<typeof screenshotModePluginMock.createSetupContract>;
   let cloud: ReturnType<typeof cloudMock.createSetup>;

   beforeEach(() => {
      mockInitializerContext = coreMock.createPluginInitializerContext();
      home = homePluginMock.createSetupContract();
      screenshotMode = screenshotModePluginMock.createSetupContract();
      cloud = cloudMock.createSetup(); 
   });

   it('do some stuff', () => { ... })

})

[Bamieh]

I'm not fully on board with adding if statements based on isCloudEnabled or not. I'd rather build this logic based on a config we already have like telemetry.allowChangingOptInStatus or add a new config for Cloud to set to hide the notice rather than using these special if statements based on environment.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 33747b9
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
telemetry	27.5KB	27.6KB	+74.0B

History

• 💚 Build #32517 succeeded 58eaaa2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gsoldevila

[afharo]

I think we are missing the changes in the kibana.json manifest to declare cloud as an optional dependency

[gsoldevila]

I'm not fully on board with adding if statements based on isCloudEnabled or not. I'd rather build this logic based on a config we already have like telemetry.allowChangingOptInStatus or add a new config for Cloud to set to hide the notice rather than using these special if statements based on environment.

Fair point! Using isCloudEnabled leaks domain details into the code. I'll create a dedicated setting in telemetry config instead.

[gsoldevila]

I'm not fully on board with adding if statements based on isCloudEnabled or not. I'd rather build this logic based on a config we already have like telemetry.allowChangingOptInStatus or add a new config for Cloud to set to hide the notice rather than using these special if statements based on environment.

Fair point! Using isCloudEnabled leaks domain details into the code. I'll create a dedicated setting in telemetry config instead.