Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting rules for formatting JSX. #12810

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

@cjcenizal cjcenizal added Team:Operations Team label for Operations Team chore blocked labels Jul 12, 2017
@cjcenizal cjcenizal force-pushed the eslint/jsx-formatting-rules branch from 5477a37 to 8c4ca3b Compare July 25, 2017 15:48
@cjcenizal cjcenizal requested review from kimjoar and weltenwort July 25, 2017 15:48
Copy link
Contributor

@kimjoar kimjoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look sane to me. When merged it would be great if you ship a new version and PR it against both kibana and xpack.

@cjcenizal cjcenizal force-pushed the eslint/jsx-formatting-rules branch from 8c4ca3b to 12405b9 Compare July 26, 2017 14:48
@cjcenizal cjcenizal merged commit b3ffd99 into elastic:master Jul 26, 2017
@cjcenizal cjcenizal deleted the eslint/jsx-formatting-rules branch July 26, 2017 15:51
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jul 26, 2017
* Add linting rules for formatting JSX.
* Bump eslint config version to 0.8.0.
cjcenizal added a commit that referenced this pull request Jul 26, 2017
* Add linting rules for formatting JSX.
* Bump eslint config version to 0.8.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants