-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hides unknown uiSettings from the advanced settings page #128030
Merged
TinaHeiligers
merged 7 commits into
elastic:main
from
TinaHeiligers:advanced-settings-hide-unknown
Mar 21, 2022
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
291ab96
Hides unregistered uiSettings in the AS page
TinaHeiligers 6a17334
Merge branch 'main' into advanced-settings-hide-unknown
TinaHeiligers e4be4aa
Adds unit test for filtering out custom settings
TinaHeiligers 55a8fb9
adds newline back to file
TinaHeiligers 2190582
Merge branch 'main' into advanced-settings-hide-unknown
kibanamachine a212207
Typescript fix
TinaHeiligers de45f82
Merge branch 'main' into advanced-settings-hide-unknown
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a flag that we can use to filter out any settings that aren't explicitly registered during Kibana setup and start lifecycles and don't need to necessarily add another one.