-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Xy gap settings #127749
[Lens] Xy gap settings #127749
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@flash1293 I am sorry if my question is silly but I am confused a bit. Here we mention that by default we are hiding the gaps but by default the So this confuses me a bit. Include empty rows feels like filling the gaps to me. |
@stratoula its showing at the table level (having rows without a metric value in the table), but hiding at the chart level. Should we change the wording? Or maybe the default? We could do linear interpolation by default maybe. |
@flash1293 we changed it to linear by default to our agg-based visualizations. Maybe it makes sense to also do it for Lens? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After Joe's explanation, I tested it locally with many combinations. Code LGTM. It works as expected 👍
@stratoula To improve a bit, I changed the copy to |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Fixes #117280
Fixes #72691
This PR adds controls for the style of interpolated regions (either use dotted lines or regular style) as well as controls for end values.
This depends on #127453 to work right (otherwise there are no empty buckets to do fitting on)