Proxy support for plugin installer

package.json

@@ -129,15 +129,16 @@
     "expose-loader": "0.7.0",
     "extract-text-webpack-plugin": "0.8.2",
     "file-loader": "0.8.4",
-    "font-awesome": "4.4.0",
     "flot-charts": "0.8.3",
+    "font-awesome": "4.4.0",
     "glob": "5.0.13",
     "glob-all": "3.0.1",
     "good-squeeze": "2.1.0",
     "gridster": "0.5.6",
     "h2o2": "5.1.1",
     "handlebars": "4.0.5",
     "hapi": "14.2.0",
+    "http-proxy-agent": "1.0.0",
     "imports-loader": "0.6.4",
     "inert": "4.0.2",
     "jade": "1.11.0",

src/cli_plugin/install/downloaders/http.js

@@ -2,11 +2,47 @@ import Wreck from 'wreck';
 import Progress from '../progress';
 import { fromNode as fn } from 'bluebird';
 import { createWriteStream } from 'fs';
+import HttpProxyAgent from 'http-proxy-agent';
+import URL from 'url';
 
-function sendRequest({ sourceUrl, timeout }) {
+function getProxyAgent(sourceUrl, logger) {
+  const httpProxy = process.env.http_proxy || process.env.HTTP_PROXY;
+  // we have a proxy detected, lets use it
+  if (httpProxy) {
+    logger.log(`Picked up proxy ${httpProxy} from http_proxy environment variable.`);
+    // get the hostname of the sourceUrl
+    const hostname = URL.parse(sourceUrl).hostname;
+    const noProxy = process.env.no_proxy || process.env.NO_PROXY || '';
+    const excludedHosts = noProxy.split(',');
+
+    // proxy if the hostname is not in noProxy
+    const shouldProxy = (excludedHosts.indexOf(hostname) === -1);
+
+    if (shouldProxy) {
+      logger.log(`Use proxy to download plugin.`);
+      logger.log(`Hint: you can add ${hostname} to the no_proxy environment variable, `
+        + `to exclude that host from proxying.`);
+      return new HttpProxyAgent(httpProxy);
+    } else {
+      logger.log(`Found exception for host ${hostname} in no_proxy environment variable. `
+        + `Skipping proxy.`);
+    }
+  }
+
+  return null;
+}
+
+function sendRequest({ sourceUrl, timeout }, logger) {
   const maxRedirects = 11; //Because this one goes to 11.
   return fn(cb => {
-    const req = Wreck.request('GET', sourceUrl, { timeout, redirects: maxRedirects }, (err, resp) => {
+    const reqOptions = { timeout, redirects: maxRedirects };
+    const proxyAgent = getProxyAgent(sourceUrl, logger);
+
+    if (proxyAgent) {
+      reqOptions.agent = proxyAgent;
+    }
+
+    const req = Wreck.request('GET', sourceUrl, reqOptions, (err, resp) => {
       if (err) {
         if (err.code === 'ECONNREFUSED') {
           err = new Error('ENOTFOUND');
@@ -50,7 +86,7 @@ Responsible for managing http transfers
 */
 export default async function downloadUrl(logger, sourceUrl, targetPath, timeout) {
   try {
-    const { req, resp } = await sendRequest({ sourceUrl, timeout });
+    const { req, resp } = await sendRequest({ sourceUrl, timeout }, logger);
 
     try {
       const totalSize = parseFloat(resp.headers['content-length']) || 0;