Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix links to Agent logs for apm, endpoint, synthetics, osquery #127480

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[Fleet] Fix links to Agent logs for apm, endpoint, synthetics, osquery #127480

merged 1 commit into from
Mar 10, 2022

Conversation

joshdover
Copy link
Contributor

Summary

This fixes the "View logs" button on the Agent detail view to link to the filtered view for the following integrations:

  • APM
  • Synthetics
  • Endpoint
  • OSQuery

image

image

@joshdover joshdover added release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.1.1 v7.17.2 labels Mar 10, 2022
@joshdover joshdover requested a review from a team as a code owner March 10, 2022 15:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

kpollich
kpollich approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 662.8KB 663.1KB +235.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit e2ff008 into elastic:main Mar 10, 2022
@joshdover joshdover deleted the fleet/fix-agent-log-filters branch March 10, 2022 17:40
@kibanamachine kibanamachine mentioned this pull request Mar 10, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Mar 10, 2022
@joshdover
[Fleet] Fix links to Agent logs for apm, endpoint, synthetics, osquery (
11b4394 
#127480)

(cherry picked from commit e2ff008)
kibanamachine pushed a commit that referenced this pull request Mar 10, 2022
@joshdover
[Fleet] Fix links to Agent logs for apm, endpoint, synthetics, osquery (
c0a9752 
#127480)

(cherry picked from commit e2ff008)
@kibanamachine kibanamachine mentioned this pull request Mar 10, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 10, 2022
@kibanamachine @joshdover
[Fleet] Fix links to Agent logs for apm, endpoint, synthetics, osquery (
c12c315 
#127480) (#127496)

(cherry picked from commit e2ff008)

Co-authored-by: Josh Dover <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 10, 2022
@kibanamachine @joshdover
[Fleet] Fix links to Agent logs for apm, endpoint, synthetics, osquery (
e1b2149 
#127480) (#127495)

(cherry picked from commit e2ff008)

Co-authored-by: Josh Dover <[email protected]>
@jen-huang jen-huang mentioned this pull request Mar 18, 2022
Merged
@dedemorton dedemorton mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

@kpollich kpollich kpollich approved these changes

Assignees

@joshdover joshdover

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.17.2 v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joshdover @elasticmachine @kibana-ci @kibanamachine @kpollich @criamico