Ensure tooltips are labeled with percentage values #12746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
Feature:Visualizations
ppisljar
requested changes
Jul 11, 2017
| return pre += this.type.makeLabel(this); | ||
| }; | ||
|
|
||
| AggConfig.prototype.isPercentage = function () { |
There was a problem hiding this comment.
actually this is creating couplings that shouldn''t be there ... agg_config shouldn't have to know anything about vislib.
also it probably shouldn't have to know anything about percentage options and such.
i think vislib should take care of this when rendering the tooltip.
|
Not seeing the percentage with the following configuration in makelogs Metric: Count
cc: @thomasneirynck |
thomasneirynck
force-pushed
the
fix/percentageFormatting
branch
from
64c8ca8 to
c034a05
Compare
1 task
thomasneirynck
force-pushed
the
fix/percentageFormatting
branch
from
c034a05 to
e811eb9
Compare
|
Closing this in favor of #13212. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: Tooltips now correcly show the percentage value if a Y-axis indicates percentage.
Closes #12391.