Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Endpoint] Add blocklist tab in policy view #127458

Merged
merged 3 commits into from
Mar 14, 2022
Merged

[Security Solution] [Endpoint] Add blocklist tab in policy view #127458

merged 3 commits into from
Mar 14, 2022

Conversation

dasansol92
Copy link
Contributor

@dasansol92 dasansol92 commented Mar 10, 2022 •
edited
Loading

Summary

  • Adds blocklists tab in policy view: a240732

blocklist in policy tab

For maintainers

@dasansol92 dasansol92 added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.2.0 labels Mar 10, 2022
@dasansol92 dasansol92 marked this pull request as ready for review March 10, 2022 13:56
@dasansol92 dasansol92 requested a review from a team as a code owner March 10, 2022 13:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92 dasansol92 marked this pull request as draft March 10, 2022 13:58
@dasansol92 dasansol92 requested a review from paul-tavares March 10, 2022 14:47
@dasansol92 dasansol92 marked this pull request as ready for review March 10, 2022 14:47
@kevinlog
Copy link
Contributor

Checked it out and tried it - looks great!

Policy list looks good:

Can add options:
image

Can remove:
image

Can view/expand options:
image

Checked links navigating around the app they worked as expected.

Empty list links worked, "Manage blocklist" link worked, "View full details" worked

LGTM!

paul-tavares
paul-tavares approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

🚢 it

@kevinlog
Copy link
Contributor

@elasticmachine merge upstream

@kevinlog kevinlog enabled auto-merge (squash) March 14, 2022 13:26
@kevinlog kevinlog added the backport:skip This commit does not require backporting label Mar 14, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2905 2906 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB +6.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit 6d87f12 into elastic:main Mar 14, 2022
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@dasansol92 @kibanamachine @maksimkovalev
[Security Solution] [Endpoint] Add blocklist tab in policy view (elas…
634ae6e 
…tic#127458)

* Adds blocklists tab in policy detail view

* Fixes wrong .id on normalize function

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@kevinlog kevinlog kevinlog approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dasansol92 @elasticmachine @kevinlog @kibana-ci @ashokaditya @paul-tavares @kibanamachine