Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FieldFormats] fix color editor crash on invalid regexp #127292

Merged
merged 3 commits into from
Mar 14, 2022
Merged

[FieldFormats] fix color editor crash on invalid regexp #127292

merged 3 commits into from
Mar 14, 2022

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Mar 9, 2022 •
edited
Loading

Summary

fix #123353

Release notes

Fix field format color editor crash on invalid color value

@Dosant Dosant added release_note:fix Team:AppServicesUx v8.1.1 v8.2.0 Feature:FieldFormatters bug Fixes for quality problems that affect the customer experience auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 9, 2022
@Dosant
Copy link
Contributor Author

Dosant commented Mar 9, 2022

@elasticmachine merge upstream

@Dosant Dosant marked this pull request as ready for review March 9, 2022 16:55
@Dosant Dosant requested a review from a team as a code owner March 9, 2022 16:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@Dosant Dosant requested a review from mattkime March 9, 2022 16:55
@Dosant
Copy link
Contributor Author

Dosant commented Mar 14, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #18 / apis Machine Learning filters get_filters should return 400 if filterId does not exist

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fieldFormats 47.7KB 47.8KB +32.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mattkime
mattkime approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, I'd backport to 8.0 and 7.17.x if needed.

@Dosant Dosant added the v7.17.2 label Mar 14, 2022
@Dosant Dosant merged commit b4b08a5 into elastic:main Mar 14, 2022
@kibanamachine kibanamachine mentioned this pull request Mar 14, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Mar 14, 2022
@Dosant
fix ff color editor crash (#127292)
a30d431 
(cherry picked from commit b4b08a5)
kibanamachine pushed a commit that referenced this pull request Mar 14, 2022
@Dosant
fix ff color editor crash (#127292)
7232493 
(cherry picked from commit b4b08a5)
@kibanamachine kibanamachine mentioned this pull request Mar 14, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 14, 2022
@kibanamachine @Dosant
fix ff color editor crash (#127292) (#127607)
06d7edf 
(cherry picked from commit b4b08a5)

Co-authored-by: Anton Dosov <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 14, 2022
@kibanamachine @Dosant
fix ff color editor crash (#127292) (#127606)
5151a3e 
(cherry picked from commit b4b08a5)

Co-authored-by: Anton Dosov <[email protected]>
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@Dosant @maksimkovalev
fix ff color editor crash (elastic#127292)
dff31ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:FieldFormatters release_note:fix v7.17.2 v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution]Runtime Field , set Format section getting broken by open Parenthesis
5 participants
@Dosant @elasticmachine @kibana-ci @kibanamachine @mattkime