[Security Solution] Unskip alerts related Cypress tests #127187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
added
Team: SecuritySolution
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
MadameSheema
added
auto-backport
jamster10
approved these changes
Mar 9, 2022
jamster10
suggested changes
Mar 9, 2022
|
@elasticmachine merge upstream |
|
@jamster10 after digging more, I saw that the tests were not flaky, just we needed to update some things in order to align with the current main. i.e. bad locators. If everything works fine, I would deeply appreciate you don't block the PR since it is pretty important to have all the tests back. |
|
Exceptions tests will remain skipped since it needs more investigation. Those will unskipped in a different PR since we need to have the other tests back to live ASAP. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jamster10
approved these changes
Mar 10, 2022
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Mar 10, 2022
* unskip tests * fixing tests * adding missing lines * updates locator * fixes check issues * keeping exceptions tests skipped since it needs more investigation Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 8604a3e) # Conflicts: # x-pack/plugins/security_solution/cypress/integration/exceptions/from_alert.spec.ts # x-pack/plugins/security_solution/cypress/integration/exceptions/from_rule.spec.ts # x-pack/plugins/security_solution/cypress/integration/users/user_details.spec.ts # x-pack/plugins/security_solution/cypress/screens/alerts.ts
This was referenced Mar 10, 2022
MadameSheema
added a commit
that referenced
this pull request
Mar 10, 2022
…27485) * unskip tests * fixing tests * adding missing lines * updates locator * fixes check issues * keeping exceptions tests skipped since it needs more investigation Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 8604a3e) # Conflicts: # x-pack/plugins/security_solution/cypress/integration/exceptions/from_alert.spec.ts # x-pack/plugins/security_solution/cypress/integration/exceptions/from_rule.spec.ts # x-pack/plugins/security_solution/cypress/integration/users/user_details.spec.ts # x-pack/plugins/security_solution/cypress/screens/alerts.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that the issue elastic/elasticsearch#84256 has been fixed, we can unskip all the alert related tests.