[Maps] Add support for geohex_grid aggregation #127170

nreese · 2022-03-08T16:57:17Z

This PR updates cluster layers with hexagons.

documentation updates https://kibana_127170.docs-preview.app.elstc.co/diff

Cluster layers are added to map by selecting "Clusters" wizard. Notice copy and icon updates.

Users now have option to select Hexagons to display clusters as hexagons. Tooltip added to describe options and provide disabled message. Hexagons only support geo_point fields. Hexagon aggregation is licensed basic in cloud and gold in on prem.

mdefazio · 2022-03-09T17:45:04Z

@nreese Following from our conversation on Slack, I put together a few options for the 'Show as' configuration. I didn't dig too far into this, but based on the following criteria I put together 2 options to consider.

Need to explain why a field is no longer available (based on field type)
Would like to allow user to discover new options for displaying clusters, even if not in their license level.

Options:

Perhaps just a simple tooltip could work so users might understand why an option is no longer available. The copy could likely be improved upon, but just showing the overall idea.

Could also consider simply showing as radio buttons. This will give more flexibility in what you want to show and perhaps also afford the option to guide the user which option is best. We could also include the tooltip option above for this as well.

Again, just some quick thoughts and happy to dig more into this—i'm guessing there's a few states of this form that I'm not considering.

nreese · 2022-03-14T21:17:52Z

@elasticmachine merge upstream

nreese · 2022-03-15T16:00:05Z

@mdefazio I decided to go with the first option and provide a tooltip on the label. What do you think?

mdefazio · 2022-03-15T17:43:12Z

@nreese With this much copy, I think it's best to have this be a popover as opposed to a tooltip so the user doesn't have to keep their cursor stationary while reading. The link is also likely more visible/likely to be clicked on than the tooltip icon. If we want to stick with the tooltip, perhaps shortening this and then using the right side link to go to docs for these options?

Is the concern that users won't know the difference between them? Or why some options are available depending on the field selected? Do we need to describe each with this much detail? With the popover, we could try and provide a small visualization next to each.

I think you could also keep line 'Hexbins require geo_point field' visible as help text for the button group, again assuming the requirement here is to let users know why an option is disabled.

Here's a quick mockup using the popover. Popover title is maybe not necessary.

nreese · 2022-03-15T17:57:37Z

Component is also displayed in column mode. So popover will need to stick with an icon but I can switch to a popover

mdefazio · 2022-03-15T18:42:32Z

If we trim down the copy, I think the tooltip is fine (and we then also stick with exisiting patterns for the label + tooltip). My main concern is just the length of that copy.

nreese · 2022-03-15T18:47:47Z

If we trim down the copy, I think the tooltip is fine (and we then also stick with exisiting patterns for the label + tooltip). My main concern is just the length of that copy.

What would you trim?

mdefazio

This is a stab at updating the copy—hopefully i'm not changing definitions here, but trying to get them into single sentences.

...ck/plugins/maps/public/classes/sources/es_geo_grid_source/render_as_select/show_as_label.tsx

nreese · 2022-03-17T19:07:44Z

@elasticmachine merge upstream

nreese · 2022-03-17T19:14:19Z

This is a stab at updating the copy—hopefully i'm not changing definitions here, but trying to get them into single sentences.

Thanks I have incorporated the suggestions.

nreese · 2022-03-18T15:22:54Z

@elasticmachine merge upstream

x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/clusters_layer_wizard.tsx

...plugins/maps/public/classes/sources/es_geo_grid_source/render_as_select/render_as_select.tsx

gchaps

LGTM with addition of a link to the subscription page.

gchaps · 2022-03-18T19:11:25Z

...plugins/maps/public/classes/sources/es_geo_grid_source/render_as_select/render_as_select.tsx

+  if (!getIsCloud() && !getIsGoldPlus()) {
+    isHexDisabled = true;
+    hexDisabledReason = i18n.translate('xpack.maps.hexbin.license.disabledReason', {
+      defaultMessage: '{hexLabel} is a subscription feature.',


This should be:

xxx is a subscription feature.

Should links be in tooltips? There is no way to click the link.

Correct. Do you have a quick screenshot of where this copy is? Can see if there are maybe some other options.

nreese · 2022-03-21T14:04:48Z

@elasticmachine merge upstream

elasticmachine · 2022-03-21T14:04:53Z

Pinging @elastic/kibana-gis (Team:Geo)

nickpeihl

lgtm! code review and tested in chrome.

x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/clusters_layer_wizard.tsx

x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/create_source_editor.js

x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/es_geo_grid_source.tsx

…es_geo_grid_source.tsx Co-authored-by: Nick Peihl <[email protected]>

nreese · 2022-03-22T15:05:20Z

@elasticmachine merge upstream

nreese · 2022-03-22T19:32:27Z

@elasticmachine merge upstream

kibana-ci · 2022-03-22T20:59:14Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`maps`	773	777	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	2.5MB	2.5MB	+3.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`maps`	68.2KB	68.4KB	+193.0B

History

💚 Build #32679 succeeded 98c1330
💚 Build #32201 succeeded 01f2eeb
💚 Build #31955 succeeded af35df2
💔 Build #31946 failed e1ea2b3
💚 Build #31910 succeeded 8fedffe
💔 Build #31841 failed 7247a53

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese added 2 commits March 8, 2022 09:55

[Maps] hex bin gridding

f4428e3

remove console.log

f01e12a

nreese mentioned this pull request Mar 8, 2022

[maps] add hexbin to ClustersLayerIcon #127188

Closed

nreese added 4 commits March 8, 2022 12:44

disable hexbins for license and geo_shape

b3930b0

fix jest tests

39baddc

copy cleanup

567beb0

label

18bee27

kibanamachine and others added 2 commits March 14, 2022 17:17

Merge branch 'main' into hex

489cb79

update clusters SVG with hexbins

327b959

nreese added 2 commits March 15, 2022 10:01

show as tooltip

fca22a7

documenation updates

7273133

mdefazio reviewed Mar 15, 2022

View reviewed changes

kibanamachine and others added 2 commits March 17, 2022 15:07

Merge branch 'main' into hex

b724767

copy updates

d90f6e0

add API test for hex

aaf5741

nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This commit does not require backporting v8.2.0 labels Mar 17, 2022

nreese added 2 commits March 17, 2022 13:51

test cleanup

67ba15d

eslint

4285e36

nreese added 3 commits March 18, 2022 08:27

eslint and functional test fixes

8d3addd

merge with main

2da8b54

eslint, copy updates, and more doc updates

c1ee20e

kibanamachine and others added 3 commits March 18, 2022 11:22

Merge branch 'main' into hex

7247a53

fix i18n error

a4c9cee

consolidate isMvt logic

73206d9

gchaps reviewed Mar 18, 2022

View reviewed changes

copy review feedback

8fedffe

nreese requested a review from gchaps March 18, 2022 18:51

gchaps approved these changes Mar 18, 2022

View reviewed changes

nreese added 2 commits March 18, 2022 15:49

use 3 stop scale for hexs

e1ea2b3

jest snapshot updates

af35df2

nreese marked this pull request as ready for review March 21, 2022 14:04

Merge branch 'main' into hex

01f2eeb

nreese requested a review from a team as a code owner March 21, 2022 14:04

nickpeihl approved these changes Mar 22, 2022

View reviewed changes

Update x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/…

45d97eb

…es_geo_grid_source.tsx Co-authored-by: Nick Peihl <[email protected]>

Merge branch 'main' into hex

98c1330

Merge branch 'main' into hex

fdf1719

nreese merged commit 75f8ac4 into elastic:main Mar 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] Add support for geohex_grid aggregation #127170

[Maps] Add support for geohex_grid aggregation #127170

nreese commented Mar 8, 2022 •

edited

Loading

mdefazio commented Mar 9, 2022

nreese commented Mar 14, 2022

nreese commented Mar 15, 2022

mdefazio commented Mar 15, 2022

nreese commented Mar 15, 2022

mdefazio commented Mar 15, 2022

nreese commented Mar 15, 2022

mdefazio left a comment

nreese commented Mar 17, 2022

nreese commented Mar 17, 2022

nreese commented Mar 18, 2022

gchaps left a comment

gchaps Mar 18, 2022

nreese Mar 18, 2022

mdefazio Mar 18, 2022

nreese Mar 18, 2022

nreese commented Mar 21, 2022

elasticmachine commented Mar 21, 2022

nickpeihl left a comment

nreese commented Mar 22, 2022

nreese commented Mar 22, 2022

kibana-ci commented Mar 22, 2022

[Maps] Add support for geohex_grid aggregation #127170

[Maps] Add support for geohex_grid aggregation #127170

Conversation

nreese commented Mar 8, 2022 • edited Loading

mdefazio commented Mar 9, 2022

nreese commented Mar 14, 2022

nreese commented Mar 15, 2022

mdefazio commented Mar 15, 2022

nreese commented Mar 15, 2022

mdefazio commented Mar 15, 2022

nreese commented Mar 15, 2022

mdefazio left a comment

Choose a reason for hiding this comment

nreese commented Mar 17, 2022

nreese commented Mar 17, 2022

nreese commented Mar 18, 2022

gchaps left a comment

Choose a reason for hiding this comment

gchaps Mar 18, 2022

Choose a reason for hiding this comment

nreese Mar 18, 2022

Choose a reason for hiding this comment

mdefazio Mar 18, 2022

Choose a reason for hiding this comment

nreese Mar 18, 2022

Choose a reason for hiding this comment

nreese commented Mar 21, 2022

elasticmachine commented Mar 21, 2022

nickpeihl left a comment

Choose a reason for hiding this comment

nreese commented Mar 22, 2022

nreese commented Mar 22, 2022

kibana-ci commented Mar 22, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

nreese commented Mar 8, 2022 •

edited

Loading