[XY] Expression chart. #127150

Kuznietsov · 2022-03-08T14:11:21Z

Summary

Completes part of #127115

Moved xyVis function and renderer to the separate plugin (chart_expressions/expression_xy) from Lens.
Register expression functions on the server and client sides.

Caution!

~~Blocked until #126456 will be merged.~~

Kuznietsov · 2022-03-09T11:18:43Z

@elasticmachine merge upstream

…to chart_expressions-xy

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx

Kuznietsov · 2022-03-15T12:49:46Z

@elasticmachine merge upstream

…to chart_expressions-xy

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/end_value.ts # src/plugins/chart_expressions/expression_xy/public/helpers/fitting_functions.ts # x-pack/plugins/lens/common/expressions/xy_chart/index.ts # x-pack/plugins/lens/common/expressions/xy_chart/xy_args.ts # x-pack/plugins/lens/common/expressions/xy_chart/xy_chart.ts # x-pack/plugins/lens/public/xy_visualization/types.ts # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/visual_options_popover/missing_values_option.tsx

# Conflicts: # packages/kbn-optimizer/limits.yml # src/plugins/chart_expressions/expression_xy/common/expression_functions/layer_config/annotation_layer_config.ts # src/plugins/chart_expressions/expression_xy/public/components/__snapshots__/xy_chart.test.tsx.snap # src/plugins/chart_expressions/expression_xy/public/components/reference_lines.tsx # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx # x-pack/plugins/lens/common/expressions/xy_chart/layer_config/index.ts # x-pack/plugins/lens/common/expressions/xy_chart/xy_args.ts # x-pack/plugins/lens/common/expressions/xy_chart/xy_chart.ts # x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx # x-pack/plugins/lens/public/expressions.ts # x-pack/plugins/lens/public/xy_visualization/color_assignment.ts # x-pack/plugins/lens/public/xy_visualization/expression.test.tsx # x-pack/plugins/lens/public/xy_visualization/index.ts # x-pack/plugins/lens/public/xy_visualization/state_helpers.ts # x-pack/plugins/lens/public/xy_visualization/to_expression.ts # x-pack/plugins/lens/public/xy_visualization/visualization.test.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx # x-pack/plugins/lens/public/xy_visualization/visualization_helpers.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/color_picker.tsx # x-pack/plugins/lens/public/xy_visualization/xy_suggestions.test.ts # x-pack/plugins/lens/server/expressions/expressions.ts # x-pack/plugins/lens/tsconfig.json

# Conflicts: # x-pack/plugins/lens/common/expressions/xy_chart/xy_chart.ts # x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx # x-pack/plugins/lens/public/xy_visualization/expression.test.tsx

mbondyra

Wow, enormous effort, hats off! I like that you not only moved things around but also improved code style and typings in many places 😍 Left a few comments, tested a bit and now I'll test in depth :)
UPDATE: Finished with testing, couldn't find any regression 👌🏼

src/plugins/chart_expressions/expression_xy/README.md

src/plugins/chart_expressions/expression_xy/common/types/expression_functions.ts

src/plugins/chart_expressions/expression_xy/public/components/annotations.scss

src/plugins/chart_expressions/expression_xy/public/types.ts

x-pack/plugins/lens/kibana.json

x-pack/plugins/lens/public/xy_visualization/annotations_helpers.tsx

Co-authored-by: Marta Bondyra <[email protected]>

…ocs'

# Conflicts: # x-pack/test/functional/apps/lens/show_underlying_data.ts

Kuznietsov · 2022-03-28T13:50:51Z

@elastic/ml-ui, could you, please, leave your review? thanks a lot)

mbondyra

Code LGTM! Tested on Chrome and everything works as it was before. Approved!

darnautov

ML changes LGTM

kibana-ci · 2022-03-28T15:14:25Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`expressionXY`	-	72	+72
`lens`	785	750	-35
total			+37

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`charts`	288	289	+1
`expressionXY`	-	463	+463
`lens`	363	466	+103
total			+567

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionXY`	-	28.2KB	+28.2KB
`lens`	1.1MB	1.1MB	-25.6KB
total			+2.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`lens`	44	29	-15

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`charts`	58.3KB	58.3KB	+19.0B
`expressionXY`	-	40.1KB	+40.1KB
`lens`	45.4KB	29.4KB	-16.1KB
total			+24.1KB

Unknown metric groups

API count

id	before	after	diff
`charts`	321	322	+1
`expressionXY`	-	473	+473
`lens`	438	541	+103
total			+577

async chunk count

id	before	after	diff
`expressionXY`	-	1	+1

ESLint disabled line counts

id	before	after	diff
`lens`	32	29	-3

Total ESLint disabled count

id	before	after	diff
`lens`	34	31	-3

History

💚 Build #33907 succeeded 8307b73
💔 Build #33898 failed 8139986
💚 Build #33871 succeeded f29bdcf
💚 Build #33770 succeeded ef30205
💔 Build #33760 failed 60f5645
💔 Build #33758 failed b553456

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

added xy plugin.

9388bba

Kuznietsov added the WIP Work in progress label Mar 8, 2022

Kuznietsov requested review from crob611 and alexwizp March 8, 2022 14:11

Kuznietsov self-assigned this Mar 8, 2022

kibanamachine and others added 15 commits March 9, 2022 06:18

Merge branch 'main' into chart_expressions-xy

8df9659

Added expressionXY limits.

ab72728

Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…

5747322

…to chart_expressions-xy

Added xy expression functions to the expression_xy plugin.

b4ee9c1

Moved xy to a separate plugin.

400845d

Small refactoring.

b2090f3

Fixed types.

33a06fa

Merge branch 'main' into chart_expressions-xy

d94fa4f

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx

Fixed import of scss.

663e093

Fixed imports.

cbffe77

Added required plugins.

389f933

Fixed import

90aa97a

Fixed types.

1d3a264

Changed expression names.

a78d45d

Fixed bugs, caused by the refactoring process.

35cab91

kibanamachine and others added 8 commits March 15, 2022 08:49

Merge branch 'main' into chart_expressions-xy

847b3c4

Fixed lens snapshots.

ed7f8ea

Removed new line.

b6daa5d

Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…

bda6524

…to chart_expressions-xy

Fixed xy_chart tests.

c8d40fe

Added lazy loading for xy chart.

5fed60c

Fixed xy chart test.

dc195b2

Fixed broken chart selectors.

d39681f

Kuznietsov added 12 commits March 23, 2022 18:31

First try to fix merge conflicts.

21e34b4

Fixed annotatations.

9cc22c8

Fixed types.

a99a223

Updated snapshots

b553456

Merge branch 'main' into chart_expressions-xy

60f5645

# Conflicts: # x-pack/plugins/lens/common/expressions/xy_chart/xy_chart.ts # x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx # x-pack/plugins/lens/public/xy_visualization/expression.test.tsx

Fixed tests.

dec0d18

Fixed dependencies.

628ade6

Fixed i18n.

cc63956

Moved XY state types to lens.

0e4092d

Fixed more types.

ef30205

Kuznietsov removed WIP Work in progress blocked labels Mar 28, 2022

Merge branch 'main' into chart_expressions-xy

f29bdcf

Kuznietsov changed the title ~~[WIP][XY] Expression chart.~~ [XY] Expression chart. Mar 28, 2022

mbondyra reviewed Mar 28, 2022

View reviewed changes

Kuznietsov and others added 7 commits March 28, 2022 13:03

Update src/plugins/chart_expressions/expression_xy/README.md

8139986

Co-authored-by: Marta Bondyra <[email protected]>

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

8307b73

…ocs'

Removed yConfig from *Layers types

500fb78

Fixed styles.

839b023

Fixed types.

b61e59a

Removed not used utils and styles.

53a6659

Merge branch 'main' into chart_expressions-xy

490159a

# Conflicts: # x-pack/test/functional/apps/lens/show_underlying_data.ts

mbondyra approved these changes Mar 28, 2022

View reviewed changes

darnautov approved these changes Mar 28, 2022

View reviewed changes

alexwizp approved these changes Mar 28, 2022

View reviewed changes

Kuznietsov merged commit 072fe63 into elastic:main Mar 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XY] Expression chart. #127150

[XY] Expression chart. #127150

Kuznietsov commented Mar 8, 2022 •

edited

Loading

Kuznietsov commented Mar 9, 2022

Kuznietsov commented Mar 15, 2022

mbondyra left a comment •

edited

Loading

Kuznietsov commented Mar 28, 2022

mbondyra left a comment

darnautov left a comment

kibana-ci commented Mar 28, 2022

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

[XY] Expression chart. #127150

[XY] Expression chart. #127150

Conversation

Kuznietsov commented Mar 8, 2022 • edited Loading

Summary

Caution!

Kuznietsov commented Mar 9, 2022

Kuznietsov commented Mar 15, 2022

mbondyra left a comment • edited Loading

Choose a reason for hiding this comment

Kuznietsov commented Mar 28, 2022

mbondyra left a comment

Choose a reason for hiding this comment

darnautov left a comment

Choose a reason for hiding this comment

kibana-ci commented Mar 28, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

Kuznietsov commented Mar 8, 2022 •

edited

Loading

mbondyra left a comment •

edited

Loading