Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing ES client maxSockets #126937

Merged
merged 11 commits into from
Mar 16, 2022
Merged

Allow customizing ES client maxSockets #126937

merged 11 commits into from
Mar 16, 2022

Conversation

gsoldevila
Copy link
Contributor

Closes #119612

@gsoldevila gsoldevila requested a review from a team as a code owner March 4, 2022 16:49
@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.2.0 labels Mar 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

afharo
afharo requested changes Mar 4, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just think we can declare it as required because the schema already fallbacks to Infinity. Also, please fix the broken tests :)

src/core/server/elasticsearch/elasticsearch_config.ts Outdated Show resolved Hide resolved
@gsoldevila gsoldevila requested a review from a team as a code owner March 7, 2022 09:28
@gsoldevila
Copy link
Contributor Author

@elasticmachine merge upstream

@gsoldevila gsoldevila requested review from pgayvallet and afharo March 7, 2022 12:46
pgayvallet
pgayvallet approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/server/elasticsearch/client/client_config.ts Outdated Show resolved Hide resolved
src/core/server/elasticsearch/elasticsearch_config.ts Outdated Show resolved Hide resolved
src/core/server/elasticsearch/elasticsearch_config.test.ts Show resolved Hide resolved
weltenwort
weltenwort approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monitoring plugin changes LGTM

@gsoldevila gsoldevila enabled auto-merge (squash) March 16, 2022 16:19
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
core 2370 2371 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gsoldevila gsoldevila merged commit bbddc42 into elastic:main Mar 16, 2022
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@gsoldevila @kibanamachine @maksimkovalev
Allow customizing ES client maxSockets (elastic#126937)
237a58f 
* Allow customizing ES client maxSockets

* Make maxSockets required (schema defaults to Infinity)

* Fix UTs

* Misc tweaks + extra UTs

* Update asciidoc

* Code cleanup

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126937 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126937 or prevent reminders by adding the backport:skip label.

@gsoldevila gsoldevila self-assigned this Mar 22, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126937 or prevent reminders by adding the backport:skip label.

@pgayvallet pgayvallet added the backport:skip This commit does not require backporting label Mar 23, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@weltenwort weltenwort weltenwort approved these changes

Assignees

@gsoldevila gsoldevila

Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make elasticsearch.maxSockets configurable
7 participants
@gsoldevila @elasticmachine @kibana-ci @kibanamachine @weltenwort @pgayvallet @afharo