-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #12685 - Improve error handling for TSVB #12688
Conversation
…ggregations key.
Woah, I've never seen this state before! @snide Have you seen this? |
No but reminds me of the multiple permission display one that came in a couple days ago. |
@simianhacker How can we trigger this error to repro your screenshot? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message pointing the user to incorrect permissions also shows up when entering an index pattern that does not match any indices. Maybe we should include that in the message as well, e.g. "The aggregations key is missing from the response. Please check the index pattern and your permissions for reading from it."?
Closes #12685. |
@simianhacker makes sense to change to add that info to the error message as well? If so, we can probably go ahead and merge this. thx, |
This PR improves the error handling for Javascript thrown errors on the server. It also adds more details to permission errors which is caused by a missing aggregation key.