-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions] Small telemetry fixes #126831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change @FrankHassanabad
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Friendly reminder: Looks like this PR hasn’t been backported yet. |
⚪ Backport skippedThe pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Summary
Small fixes and just a few docs to clarify things. I might be wrong on what I'm doing, so please let me know.
Looking at the telemetry data from servers I see things like this (I made this up, not real data, but the shape of the data is the same as what we see on the servers):
and I also see the views which is 👍 what I would make the dashboards from ... So not for sure if the structure above this is legacy. I could not get the shape of data above to happen locally. However, this shape below seems better and what I would create dashboards from.
With this new key of "securitySolutionUI" I don't see keys like
securitySolutionUI:overview
but I do see the views like above so let me know if changing the keys here in some areas are a mistake or not or if this is not the right thing to do.Ref to earlier PR with the new key of
securitySolutionUI
fromAPP_ID
changing:#113573