[yarn] download prebuilt artifacts for re2 and node-sass from custom mirrors #126820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
spalger
force-pushed
the
implement/prebuilt-mirrors
branch
from
53c17da to
802d511
Compare
spalger
added
the
auto-backport
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
requested changes
Mar 3, 2022
|
@elasticmachine merge upstream |
jbudz
approved these changes
Mar 3, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 3, 2022
…mirrors (elastic#126820) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c509fda) # Conflicts: # yarn.lock
spalger
pushed a commit
that referenced
this pull request
Mar 3, 2022
…ustom mirrors (#126820) (#126855) * [yarn] download prebuilt artifacts for re2 and node-sass from custom mirrors (#126820) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c509fda) # Conflicts: # yarn.lock * update kbn/pm dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than run build scripts on M1 Mac machines to take care of missing native packages for
node-sassandre2packages, we publish our own builds of these modules that we will download during yarn-install via custom mirrors and environment variables which customize the post-install scripts. This will ensure that everyone has the same artifacts and therefore can utilize the bazel remote cache.To do this we need to publish all the build artifacts for each version to a bucket, along with the artifact for the darwin-arm64 build. This means we won't be able to update Node or these two packages without pushing up new artifacts, but hopefully this will be a very short lived thing until the upstream repos can start publishing M1 compatible artifacts.