Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade Assistant] Add deprecation logging as step on overview page #126693

Merged
merged 4 commits into from
Mar 14, 2022
Merged

[Upgrade Assistant] Add deprecation logging as step on overview page #126693

merged 4 commits into from
Mar 14, 2022

Conversation

alisonelizabeth
Copy link
Contributor

Forwardport of #126277

@alisonelizabeth alisonelizabeth added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v8.2.0 v8.0.1 v8.1.1 labels Mar 2, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
upgradeAssistant 186 188 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 167.7KB 171.1KB +3.4KB
Unknown metric groups

ESLint disabled line counts

id before after diff
upgradeAssistant 10 11 +1

Total ESLint disabled count

id before after diff
upgradeAssistant 10 11 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth marked this pull request as ready for review March 14, 2022 12:14
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner March 14, 2022 12:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

sabarasaba
sabarasaba approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, didnt test locally 🚀

@alisonelizabeth alisonelizabeth merged commit f4358d5 into elastic:main Mar 14, 2022
@alisonelizabeth alisonelizabeth deleted the ua/forwardport-126277 branch March 14, 2022 15:56
@alisonelizabeth alisonelizabeth mentioned this pull request Mar 14, 2022
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Mar 14, 2022
@alisonelizabeth
[Upgrade Assistant] Add deprecation logging as step on overview page (e…
0737c07 
…lastic#126693)

(cherry picked from commit f4358d5)
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Mar 14, 2022
@alisonelizabeth
[Upgrade Assistant] Add deprecation logging as step on overview page (e…
bed8236 
…lastic#126693)

(cherry picked from commit f4358d5)

# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@alisonelizabeth alisonelizabeth mentioned this pull request Mar 14, 2022
Closed
alisonelizabeth added a commit that referenced this pull request Mar 14, 2022
@alisonelizabeth
[Upgrade Assistant] Add deprecation logging as step on overview page (#…
3a20601 
…126693) (#127618)

(cherry picked from commit f4358d5)
@sabarasaba sabarasaba mentioned this pull request Mar 15, 2022
Closed
@jbudz jbudz mentioned this pull request Mar 15, 2022
Merged
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@alisonelizabeth @maksimkovalev
[Upgrade Assistant] Add deprecation logging as step on overview page (e…
1c43626 
…lastic#126693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees
No one assigned
Labels
chore Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisonelizabeth @kibana-ci @elasticmachine @sabarasaba