Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Update hover actions css selector to re-hide default cell actions #126551

Merged
merged 2 commits into from
Mar 1, 2022
Merged

[Security Solution] Update hover actions css selector to re-hide default cell actions #126551

merged 2 commits into from
Mar 1, 2022

Conversation

kqualters-elastic
Copy link
Contributor

@kqualters-elastic kqualters-elastic commented Mar 1, 2022 •
edited
Loading

Summary

A recent upgrade to eui #125023 caused the css selector used by security solution to hide built in row cell hover actions https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/common/components/page/index.tsx#L38 to break, this pr updates the selector so that they are once again hidden. Can probably delete this code once elastic/eui#5132 is implemented.

Before:
image

After:
image

@kqualters-elastic kqualters-elastic added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.2.0 labels Mar 1, 2022
@kqualters-elastic kqualters-elastic requested a review from a team as a code owner March 1, 2022 01:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 245.5KB 245.6KB +34.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic kqualters-elastic merged commit f0a7f1f into elastic:main Mar 1, 2022
@kqualters-elastic kqualters-elastic deleted the update-eui-action-selector branch March 1, 2022 13:23
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 3, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126551 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126551 or prevent reminders by adding the backport:skip label.

@kqualters-elastic kqualters-elastic added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@janmonschke janmonschke janmonschke approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kqualters-elastic @kibana-ci @kibanamachine @janmonschke @michaelolo24