[Security Solution] Refactor policy details tests to focus on only fields changed #126458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlog
added
Team:Defend Workflows
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
ashokaditya
approved these changes
Feb 28, 2022
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
paul-tavares
approved these changes
Mar 1, 2022
kevinlog
added
the
auto-backport
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 1, 2022
…elds changed (elastic#126458) (cherry picked from commit bc4c8d6)
kibanamachine
added a commit
that referenced
this pull request
Mar 1, 2022
…elds changed (#126458) (#126585) (cherry picked from commit bc4c8d6) Co-authored-by: Kevin Logan <[email protected]>
|
@kevinlog, I'm going to kickoff a backport of this PR to 7.17 branch. These will help get my backport for ID changes to pass CI: #127671. This backport is for the initial changes to the input IDs which caused problems as we discussed earlier today; I am working on a subsequent fix in #127673 but this one needs to go in first. Let me know if any concerns with backporting your PR. |
jen-huang
added
auto-backport
This comment was marked as outdated.
This comment was marked as outdated.
jen-huang
pushed a commit
to jen-huang/kibana
that referenced
this pull request
Mar 15, 2022
…elds changed (elastic#126458) (cherry picked from commit bc4c8d6) # Conflicts: # x-pack/test/security_solution_endpoint/apps/endpoint/policy_details.ts
jen-huang
pushed a commit
to jen-huang/kibana
that referenced
this pull request
Mar 15, 2022
…elds changed (elastic#126458) (cherry picked from commit bc4c8d6) # Conflicts: # x-pack/test/security_solution_endpoint/apps/endpoint/policy_details.ts
jen-huang
added a commit
that referenced
this pull request
Mar 15, 2022
…elds changed (#126458) (#127682) (cherry picked from commit bc4c8d6) # Conflicts: # x-pack/test/security_solution_endpoint/apps/endpoint/policy_details.ts Co-authored-by: Kevin Logan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors policy details tests to only focus on the fields changed in the test. Looking at the entire manifest was causing consistent test flakiness. This should narrow down the tests to only focus on what changes during the automation.
You can see from the failures we get on this test, the manifest is always the reason for failure. In this PR, we remove that check and focus on the fields changed only.
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/198
Checklist