[Reporting] Give users better information when pdf fails #126171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
tsullivan
approved these changes
Feb 23, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jloleysens
deleted the
reporting/give-users-better-information-when-pdf-fails
branch
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 2, 2022
) * raise pdf worker out memory error to common errors * not having a PDF buffer for a PDF report should fail the report * remove unused import * make it possible to format Reporting errors nicely * make pdf v1 behave the same way as v2 regarding not compiling a PDF * remove unused import Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today when a PDF fails to generate a buffer we report that as a warning to users. This contribution makes a failure to generate a PDF buffer fail the report and sends a formatted message back to the user if it was due to an out-of-memory condition in the worker thread.
Screenshots
Checklist