Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] update ES client version #126129

Merged
merged 14 commits into from
Feb 24, 2022
Merged

[main] update ES client version #126129

merged 14 commits into from
Feb 24, 2022

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Feb 22, 2022 •
edited by pgayvallet
Loading

Summary

This PR

  • updates ES client to the latest version (8.1.0-canary.3)
  • updates renovate bot settings to work on 8.1 and 7.17 branches

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Feb 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mshustov mshustov changed the title Es client renovate [main] update ES client version Feb 22, 2022
@delvedor
Copy link
Member

delvedor commented Feb 22, 2022 •
edited
Loading

So, the tests fail because of a change made in elastic/elastic-transport-js#36 and elastic/elastic-transport-js#37.
Before this change, if you were passing a body as a string, the client was configuring application/json as content type by default while now is using text/plain by default.
We can either roll back the change in the client, even tho the current behavior makes more sense, or kibana should be updated to override the default content type if you are sending a json string, for example:

const response = await client.scriptsPainlessExecute({
// @ts-expect-error `ExecutePainlessScriptRequest.body` does not allow `string`
  body,
}, {
  headers: {
    'content-type': 'application/json'
  }
});

I believe you are already overriding the content type in a few cases where you are sending yaml instead of json.

@mshustov mshustov requested review from a team as code owners February 22, 2022 11:56
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@pgayvallet pgayvallet mentioned this pull request Feb 23, 2022
Closed
1 task
@mshustov mshustov requested review from a team as code owners February 23, 2022 09:45
@pgayvallet pgayvallet marked this pull request as draft February 23, 2022 09:59
@pgayvallet pgayvallet marked this pull request as ready for review February 23, 2022 14:39
@pgayvallet pgayvallet requested review from a team as code owners February 23, 2022 14:39
hop-dev
hop-dev approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM 👍

alisonelizabeth
alisonelizabeth approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform deployment management changes LGTM! Left one nit about a code comment that can be removed.

x-pack/plugins/snapshot_restore/server/routes/api/snapshots.ts Outdated Show resolved Hide resolved
x-pack/plugins/snapshot_restore/server/routes/api/snapshots.ts Outdated Show resolved Hide resolved
ymao1
ymao1 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LGTM

jloleysens
jloleysens approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting changes LGTM

jgowdyelastic
jgowdyelastic approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML and Transform changes LGTM

ThomThomson
ThomThomson approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team TS change LGTM!

@pgayvallet
Copy link
Contributor

@elasticmachine merge upstream

@pgayvallet pgayvallet enabled auto-merge (squash) February 24, 2022 20:41
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +58.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 0393f3f into elastic:main Feb 24, 2022
This was referenced Feb 25, 2022
Closed
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 28, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126129 or prevent reminders by adding the backport:skip label.

@pgayvallet pgayvallet added the backport:skip This commit does not require backporting label Mar 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 1, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@pgayvallet @kibanamachine @lucasfcosta
[main] update ES client version (elastic#126129)
8f43aec 
* update renovate bot settings

* update es client to 8.1-canary3

* specify type explicitly when pass a serialized object

* attempt 1 in fleet.specify type explicitly when pass a serialized object

* fix the first batch of ts errors

* fix more violations

* fix unit test

* fix more violations 2

* fix more violations 3

* fix more violations 4

* review comments

Co-authored-by: pgayvallet <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@ymao1 ymao1 ymao1 approved these changes

@jloleysens jloleysens jloleysens approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@hop-dev hop-dev hop-dev approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:elasticsearch release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Team label for Operations Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.