-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anomalies tab to user page #126079
Add anomalies tab to user page #126079
Conversation
skip, | ||
criteriaFields: getCriteriaFromUsersType(type, userName), | ||
filterQuery: { | ||
exists: { field: 'user.name' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/ml-ui I have to display anomalies related to users. So I only return anomalies where user.name
exists. Will it work? Do all anomalies influenced by a user have user.name
field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work if user.name
is included as one of the influencer fields for the job. Is user.name
included inside the influencers
array inside the analysis_config
for the job(s)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that user.name
should be there for all user anomalies.
I checked many auth ml configurations and user.name
was there for all of them. For example:
windows_rare_user_runas_event.json
"analysis_config": {
"bucket_span": "15m",
"detectors": [
{
"detector_description": "rare by \"user.name\"",
"function": "rare",
"by_field_name": "user.name"
}
],
"influencers": [
"host.name",
"process.name",
"user.name"
]
},
e8c08a9
to
adbf0dc
Compare
x-pack/plugins/ml/server/models/results_service/results_service.ts
Outdated
Show resolved
Hide resolved
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
...rity_solution/public/common/components/ml/influencers/get_user_name_from_influencers.test.ts
Outdated
Show resolved
Hide resolved
...gins/security_solution/public/common/components/ml/tables/convert_anomalies_to_users.test.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
x-pack/plugins/ml/server/routes/schemas/results_service_schema.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @machadoum 🚀
0502bcd
to
339ed5e
Compare
@elasticmachine merge upstream |
1 similar comment
@elasticmachine merge upstream |
merge conflict between base and head |
8fa27ed
to
84a960a
Compare
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @machadoum |
💔 Backport failedThe pull request could not be backported due to the following error: How to fixRe-run the backport manually:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
user.name
andhost.name
on the serverChecklist
Delete any items that are not applicable to this PR.
How to test it