-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Show underlying data editor navigation #125983
Merged
Merged
Changes from 35 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
8805136
:alembic: First steps
dej611 873ff6d
Merge remote-tracking branch 'upstream/main' into feature/show-underl…
dej611 fa64071
:tada: Initial implementation for button insider editor
dej611 32baaa0
:white_check_mark: fix types and tests
dej611 f659b6b
:white_check_mark: Add some tests and some test placeholders
dej611 7495712
Merge remote-tracking branch 'upstream/main' into feature/show-underl…
dej611 54bdbd2
:bug: Fix issues on mount
dej611 5b7dbe4
:fire: Remove unused attr
dej611 c938b01
:white_check_mark: Add more tests for edge cases
dej611 05163c8
:recycle: First code refactor
dej611 6206d27
:bug: Fix discover capabilities check
dej611 675b4db
:bug: Fix various issues
dej611 9dfc9d2
:white_check_mark: Add functional tests
dej611 6ddbee4
Merge remote-tracking branch 'upstream/main' into feature/show-underl…
dej611 aec1234
:white_check_mark: Add more tests
dej611 b214e75
Merge branch 'main' into feature/show-underlying-data
kibanamachine 0f10e7c
Merge branch 'main' into feature/show-underlying-data
kibanamachine 63440f3
Merge branch 'main' into feature/show-underlying-data
kibanamachine 795f9b6
Merge branch 'main' into feature/show-underlying-data
kibanamachine 71369da
:sparkles: Add support for terms + multiterms
dej611 83a08d3
:sparkles: Make link open a new window with discover
dej611 655a35e
:white_check_make: Update functional tests to deal with new tab
dej611 f9f95fd
:bug: Fix transposed table case: make it use fallback
dej611 c72219f
:bug: Fix unit tests
dej611 4eda950
Merge branch 'main' into feature/show-underlying-data
kibanamachine 44d1088
Merge remote-tracking branch 'upstream/main' into feature/show-underl…
dej611 6124dbc
:ok_hand: Address review feedback
dej611 b30862e
:bug: Skip filtered metrics if there's at least an unfiltered one
dej611 1a8153f
:bug: Improve string escaping strategy
dej611 d0297fa
Merge branch 'main' into feature/show-underlying-data
kibanamachine 0111cca
:bug: Fix functional tests and improved filters dedup checks
dej611 f0f7df5
Merge branch 'feature/show-underlying-data' of github.com:dej611/kiba…
dej611 1f6682a
:white_check_mark: Fix functional tests for formula case
dej611 972b432
:wrench: Make close editor panel more robust
dej611 6eec900
:wrench: Try focus approach
dej611 7be3ec7
:ok_hand: Rename variable
dej611 dbf8de9
:white_check_mark: Try to click outside
dej611 5f727c7
:white_check_mark: Use the keyboard arrow approach
dej611 0ad4bc3
Merge branch 'main' into feature/show-underlying-data
kibanamachine 51da4b9
Merge branch 'main' into feature/show-underlying-data
kibanamachine bda6a9d
:ok_hand: Address some issues raised by review
dej611 b464915
:white_check_mark: Fix tests and add one more for unsupported datasource
dej611 6f36675
Merge branch 'main' into feature/show-underlying-data
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name implies a boolean value. Maybe
layerMetaInfo
?