Remove XSRF Header and usage #12528
Closed
Remove XSRF Header and usage #12528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a prefilter that was applied to any angular $http request to automatically add the kbn-version header unless explicitly told to not do it. This also removes the same behavior from jQuery AJAX calls via the prefilter in the same file. These were discovered when working to resolve why Console was adding the header.
pickypg
added
Feature:Console
azasypkin
reviewed
Jun 28, 2017
| @@ -15,11 +15,11 @@ export function send(method, path, data) { | |||
| method = "POST"; | |||
| } | |||
|
|
|||
| let contentType; | |||
| // even body-less requests will be sent with JSON as the content-type to appease Kibana | |||
| let contentType = 'application/json'; | |||
There was a problem hiding this comment.
It looks like there is an open PR that trying to fix the same thing as well: #12294.
Sorry for wasting your time @pickypg :( but yesterday we decided to rollback "content-type as xsrf token" PR for 6.0 so that we can have more time to decide how to be fully compliant with ES and to not release half-baked solution for such important thing.
I still think it will be good to change our code to always pass correct content-type though, but at this point we can't get rid of old xsrf approach. What are your thoughts @epixa ?
|
As far as I can tell this is superseded by #12547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a prefilter that was applied to any angular $http request to automatically add the kbn-version header unless explicitly told to not do it.
This also removes the same behavior from jQuery AJAX calls via the prefilter in the same file.
These were discovered when working to resolve why Console was adding the header.
Closes #12527