Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1] [Canvas] Migrate by value embeddables (#123515) #125121

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Feb 9, 2022

Backport

This is an automatic backport to 8.1 of:

Questions ?

Please refer to the Backport tool documentation

* Add migrations for by value embeddables

Check for id in embeddable input

Removed unused import

Fixed tests

Fix variable name

Move migration into embeddable function definition

Remove unused code

* Cleanup

* Fix embeddable test

* Remove check for by-value embeddables in embeddable function migration

* Removed unused import

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 8e8c4b8)
@cqliu1 cqliu1 added the backport label Feb 9, 2022
@cqliu1 cqliu1 enabled auto-merge (squash) February 9, 2022 17:31
@cqliu1 cqliu1 merged commit 7b127b5 into elastic:8.1 Feb 9, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +267.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants