Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Remove unwanted overflow on Integrations screenshots #124975

Merged
merged 1 commit into from
Feb 8, 2022
Merged

[Fleet] Remove unwanted overflow on Integrations screenshots #124975

merged 1 commit into from
Feb 8, 2022

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Feb 8, 2022

Summary

Closes #122202

A recent change in EuiPagination introduced an unwanted overflow in the screenshots column in Integrations details view, since it added two buttons to quickly navigate to first and last page.

I just added a max-width property to fit the buttons in the column.

Before

Before

After

After

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 labels Feb 8, 2022
@criamico criamico self-assigned this Feb 8, 2022
@criamico criamico requested a review from a team as a code owner February 8, 2022 15:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 659.6KB 659.7KB +99.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit 30350fc into elastic:main Feb 8, 2022
@kibanamachine kibanamachine mentioned this pull request Feb 8, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2022
@criamico @kibanamachine
[Fleet] Remove unwanted overflow on Integrations screenshots (elastic…
e66a4ca 
…#124975)

(cherry picked from commit 30350fc)
kibanamachine added a commit that referenced this pull request Feb 8, 2022
@kibanamachine @criamico
[Fleet] Remove unwanted overflow on Integrations screenshots (#124975) (
a605c00 
#124995)

(cherry picked from commit 30350fc)

Co-authored-by: Cristina Amico <[email protected]>
@criamico criamico mentioned this pull request Feb 9, 2022
Closed
@criamico criamico deleted the Integrations_screenshots_width branch July 12, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@criamico criamico

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet]: Screenshots column is broken under integration overview page.
5 participants
@criamico @elasticmachine @kibana-ci @kibanamachine @nchaulet