Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Unify remove artifact from policy message and fix back buttons #124936

Conversation

dasansol92
Copy link
Contributor

Summary

  • Unify messages when removing an artifact from policy:
    unify remove from policy messages

  • Open creation flyout when adding artifacts from policy view:
    open creation flyout from policy view

  • Adds back button when clicking on view full details from policy view:
    adds back button for full details

For maintainers

@dasansol92 dasansol92 added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 labels Feb 8, 2022
@dasansol92 dasansol92 requested a review from a team as a code owner February 8, 2022 11:50
@dasansol92 dasansol92 requested review from pzl and parkiino February 8, 2022 11:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB +393.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@dasansol92 dasansol92 merged commit 939bc3d into elastic:main Feb 9, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2022
…ge and fix back buttons (elastic#124936)

* Updates delete messages for event filters and host isolation exceptions list

* Fixes back buttons when click on view full details. Open create dialog by default from artifacts policy view

* Fixes ts checks

(cherry picked from commit 939bc3d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 9, 2022
…ge and fix back buttons (#124936) (#125065)

* Updates delete messages for event filters and host isolation exceptions list

* Fixes back buttons when click on view full details. Open create dialog by default from artifacts policy view

* Fixes ts checks

(cherry picked from commit 939bc3d)

Co-authored-by: David Sánchez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants