Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Inspector displays only visible content #124677

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Feb 4, 2022

Summary

Closes #121947

This PR makes sure that we send the correct data to the table inspector.
When you enable the partial rows setting, the computation follows the same path as the 'different metrics per bucket' but we don't want to display the intermediary columns neither on the chart nor the inspector. https://github.com/elastic/kibana/blob/main/src/plugins/vis_types/table/public/to_ast.ts#L32

Although we take this under consideration on the chart, on the inspector table we send all columns. This PR makes sure that we log only the visible content.

Inspector with the partial rows on but the Show metrics for every bucket/level off
image

@stratoula stratoula changed the title [Table] Not send hidden columns to the inspector [Table] Inspector displays only visible content Feb 4, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTable 15.1KB 15.3KB +220.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Feature:Data Table Data table visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0 release_note:fix labels Feb 4, 2022
@stratoula stratoula marked this pull request as ready for review February 4, 2022 13:59
@stratoula stratoula requested a review from a team as a code owner February 4, 2022 13:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this fix works! 👍

@stratoula stratoula merged commit bf7fae9 into elastic:main Feb 4, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124677 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 8, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124677 or prevent reminders by adding the backport:skip label.

@stratoula stratoula added the backport:skip This commit does not require backporting label Feb 9, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 9, 2022
@LeeDr
Copy link

LeeDr commented Apr 18, 2022

@stratoula just checking if there should be some type of test (new test or modified test) for this PR?

@stratoula
Copy link
Contributor Author

@LeeDr I can add one for testing the inspector data when partial rows setting is on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Table Data table visualization feature release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datatable] When I enable the partial rows, the inspector shows metrics for each bucket
6 participants