-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] Inspector displays only visible content #124677
Conversation
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and this fix works! 👍
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
@stratoula just checking if there should be some type of test (new test or modified test) for this PR? |
@LeeDr I can add one for testing the inspector data when partial rows setting is on |
Summary
Closes #121947
This PR makes sure that we send the correct data to the table inspector.
When you enable the
partial rows
setting, the computation follows the same path as the 'different metrics per bucket' but we don't want to display the intermediary columns neither on the chart nor the inspector. https://github.com/elastic/kibana/blob/main/src/plugins/vis_types/table/public/to_ast.ts#L32Although we take this under consideration on the chart, on the inspector table we send all columns. This PR makes sure that we log only the visible content.
Inspector with the partial rows on but the
Show metrics for every bucket/level
off