Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] unskip flaky shapefile test #124539

Merged
merged 1 commit into from
Feb 4, 2022
Merged

[maps] unskip flaky shapefile test #124539

merged 1 commit into from
Feb 4, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 3, 2022

Fixes #124334

Unskip test and comment out expect statement that is causing flakiness

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 labels Feb 3, 2022
@nreese nreese requested a review from nickpeihl February 3, 2022 15:14
@nreese nreese requested a review from a team as a code owner February 3, 2022 15:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese changed the title [maps] unskip flacky shapefile test [maps] unskip flaky shapefile test Feb 3, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review

@nreese nreese merged commit 490bcc4 into elastic:main Feb 4, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 4, 2022
@nreese @kibanamachine
[maps] unskip flacky shapefile test (elastic#124539)
61d3176 
(cherry picked from commit 490bcc4)
@kibanamachine kibanamachine mentioned this pull request Feb 4, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 4, 2022
@kibanamachine @nreese
[maps] unskip flacky shapefile test (#124539) (#124723)
67b96a0 
(cherry picked from commit 490bcc4)

Co-authored-by: Nathan Reese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
5 participants
@nreese @elasticmachine @kibana-ci @kibanamachine @nickpeihl