Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Use timelineId to tell when investigate in timeline is in a table #124310

Merged
merged 2 commits into from
Feb 2, 2022
Merged

[Security Solution] Use timelineId to tell when investigate in timeline is in a table #124310

merged 2 commits into from
Feb 2, 2022

Conversation

kqualters-elastic
Copy link
Contributor

@kqualters-elastic kqualters-elastic commented Feb 2, 2022 •
edited by FrankHassanabad
Loading

Summary

Fixes #124307 by preventing event tables from making event detail requests when in a timeline by skipping the data fetching hook when the action is in a timeline.
0 calls to the detection detail api when viewing just the table:
image
1 made when opening the detail flyout:
image

Checklist

@kqualters-elastic kqualters-elastic changed the title Use timelineId to tell when investigate in timeline is in a table [Security Solution] Use timelineId to tell when investigate in timeline is in a table Feb 2, 2022
@FrankHassanabad FrankHassanabad added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 2, 2022
@kqualters-elastic kqualters-elastic added v8.1.0 and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 2, 2022
@kqualters-elastic kqualters-elastic added auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels Feb 2, 2022
@kqualters-elastic kqualters-elastic marked this pull request as ready for review February 2, 2022 02:41
@kqualters-elastic kqualters-elastic requested a review from a team as a code owner February 2, 2022 02:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

FrankHassanabad
FrankHassanabad approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

  • Checked this out
  • Tested it to make sure the REST calls were not being called everywhere.
  • 👍

@kqualters-elastic kqualters-elastic enabled auto-merge (squash) February 2, 2022 02:46
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB +94.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kqualters-elastic

@FrankHassanabad FrankHassanabad merged commit a6c7d96 into elastic:main Feb 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 2, 2022
@kqualters-elastic @kibanamachine
[Security Solution] Use timelineId to tell when investigate in timeli…
2482907 
…ne is in a table (elastic#124310)

## Summary

Fixes elastic#124307 by preventing event tables from making event detail requests when in a timeline by skipping the data fetching hook when the action is in a timeline.
0 calls to the detection detail api when viewing just the table:
![image](https://user-images.githubusercontent.com/56408403/152084212-4b61fb5d-240b-4921-9842-61f3e505d7c7.png)
1 made when opening the detail flyout:
![image](https://user-images.githubusercontent.com/56408403/152084244-d94ac8f5-c336-458a-b1a2-3a2780e102f4.png)

### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

(cherry picked from commit a6c7d96)
@kibanamachine kibanamachine mentioned this pull request Feb 2, 2022
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124310 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 4, 2022
@marshallmain marshallmain removed v8.0.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 4, 2022
@FrankHassanabad FrankHassanabad mentioned this pull request Feb 4, 2022
Merged
FrankHassanabad added a commit that referenced this pull request Feb 5, 2022
@FrankHassanabad
Reverts PR 124310 (#124736)
ea6347c 
## Summary

Reverts #124310 through the commands:

```sh
git revert 30f2ce4 --no-commit
git revert de32a55 --no-commit
git checkout -b 'revert-124310'
git add .
git push
```

Double check that this does look like a revert of that PR. This is for `main` only.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 7, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124310 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 7, 2022
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 8, 2022
@FrankHassanabad @kqualters-elastic
Reverts PR 124310 (elastic#124736)
e3f3b58 
## Summary

Reverts elastic#124310 through the commands:

```sh
git revert 30f2ce4 --no-commit
git revert de32a55 --no-commit
git checkout -b 'revert-124310'
git add .
git push
```

Double check that this does look like a revert of that PR. This is for `main` only.

(cherry picked from commit ea6347c)
kqualters-elastic added a commit that referenced this pull request Feb 8, 2022
@kqualters-elastic @FrankHassanabad
Reverts PR 124310 (#124736) (#125021)
0681fd1 
## Summary

Reverts #124310 through the commands:

```sh
git revert 30f2ce4 --no-commit
git revert de32a55 --no-commit
git checkout -b 'revert-124310'
git add .
git push
```

Double check that this does look like a revert of that PR. This is for `main` only.

(cherry picked from commit ea6347c)

Co-authored-by: Frank Hassanabad <[email protected]>
@kqualters-elastic kqualters-elastic deleted the fix-wild-hook-logic branch June 2, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees

@kqualters-elastic kqualters-elastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solutions] Events viewer (timeline part) is making a excessive REST calls
6 participants
@kqualters-elastic @elasticmachine @kibana-ci @kibanamachine @FrankHassanabad @marshallmain