[Security Solution][Endpoint] Add Event Filters api validations get, find, delete, export, summary and import
#124071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
release_note:skip
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
paul-tavares
requested review from
joeypoon
and removed request for
dasansol92
…vent-filters-validations-get-find-delete-export-summary # Conflicts: # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_delete_item_handler.ts # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_export_handler.ts # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_get_one_handler.ts # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_multi_list_find_handler.ts # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_single_list_find_handler.ts # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_summary_handler.ts
ashokaditya
approved these changes
Jan 31, 2022
Comment on lines
41
to
47
| return data; | ||
| } | ||
|
|
||
| // Event Filter validation | ||
| if (EventFilterValidator.isEventFilter({ listId })) { | ||
| await new EventFilterValidator(endpointAppContext, request).validatePreDeleteItem(); | ||
| return data; |
There was a problem hiding this comment.
Nice! I added this change to some of the validators in my PR as well as you suggested.
ashokaditya
reviewed
Jan 31, 2022
| @@ -5,7 +5,7 @@ | |||
| * 2.0. | |||
There was a problem hiding this comment.
I've renamed this file to event_filters.ts and also moved host isolation tests to endpoint_artifacts/host_isolation_exceptions.ts
…vent-filters-validations-get-find-delete-export-summary # Conflicts: # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_delete_item_handler.ts # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_get_one_handler.ts # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_multi_list_find_handler.ts # x-pack/plugins/security_solution/server/lists_integration/endpoint/handlers/exceptions_pre_single_list_find_handler.ts # x-pack/test/security_solution_endpoint_api_int/apis/endpoint_artifacts/event_filters.ts
joeypoon
approved these changes
Jan 31, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get,find,delete,export,summaryandimportLists APIs for Endpoint Event FiltersChecklist