[Lists] Add an instance of ExceptionListClient with server extension points turned off to context object provided to callbacks
#123885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urned off to the `context` provided to callbacks
paul-tavares
added
release_note:skip
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
paul-tavares
requested review from
FrankHassanabad,
a team,
pzl,
parkiino and
joeypoon
and removed request for
a team and
parkiino
joeypoon
approved these changes
Jan 27, 2022
ashokaditya
approved these changes
Jan 27, 2022
ashokaditya
approved these changes
Jan 27, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
yctercero
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
LGTM - just did code review (did not pull down to play around with it).
Chatted with @paul-tavares quickly. Seems what we ultimately need here is a more robust middleware solution, but this resolves a current use case 👍🏽
paul-tavares
deleted the
task/olm-add-exceptions-client-to-external-callback-context
branch
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 28, 2022
…fix-potential-race-condition-when-screenshotting * 'main' of github.com:elastic/kibana: (75 commits) [Reporting] Logging improvements while generating reports (elastic#123802) [Uptime] Default alert connectors email settings (elastic#123244) Update comparison series styles to match the main series (elastic#123858) [RAC][Uptime] remove extra dot from the uptime alert connector message (elastic#124000) [Exploratory view] Allow ability add extra actions in lens embeddable (elastic#123713) [SecuritySolution][Investigations] Add message about missing index in data view in analyzer (elastic#122859) [TSVB] Formatting in the left axis is not respected when I have two separate axis (elastic#123903) [Discover] Remove services from component dependencies (elastic#121691) Stop IM rule execution if there are no events (elastic#123811) [Security Solution][Endpoint] Update Fleet Trusted Apps and Host Isolation Exception cards to use exception list summary API (elastic#123900) [Security Solution][Exceptions] Switches modal to flyout component (elastic#123408) [Workplace Search] Fix bug where modal visible after deleting a group (elastic#123976) [Alerting] Remove state variables from action variable menu (elastic#123702) replace deprecated api usage (elastic#123970) Fix package policy merge logic for boolean values (elastic#123974) [Security Solution][Endpoint][Policy] Remove GET policy list api route (elastic#123873) Reenable alert_add test suite (elastic#123862) [Fleet] Remove usage of IFieldType in Fleet (elastic#123960) [Lists] Add an instance of `ExceptionListClient` with server extension points turned off to context object provided to callbacks (elastic#123885) [Maps] Add execution context (elastic#123651) ... # Conflicts: # x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Jan 31, 2022
…n points turned off to context object provided to callbacks (elastic#123885) * Add an instance of ExceptionListClient with server extension points turned off to the `context` provided to callbacks * Unit test cases to validate context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ExceptionListClientto thecontextobject provided to Server Extension Point callbacks. This instance of the client has the processing of the extension points turn off in order to avoid infinite loops when business logic in extension point callbacks needs to access exception list content.Checklist