Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable alert_create_flyout create alert test #123878

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Reenable alert_create_flyout create alert test #123878

merged 2 commits into from
Jan 28, 2022

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jan 26, 2022 •
edited
Loading

Summary

Fixes #89397

The alert_create_flyout test was failing because the alert flyout wasn't reliably being closed and reset to its original state in between tests. This reenables the test and fixes the issue.

Checklist

@Zacqary Zacqary added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.1.0 v8.2.0 labels Jan 26, 2022
@Zacqary Zacqary marked this pull request as ready for review January 27, 2022 17:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary enabled auto-merge (squash) January 27, 2022 21:09
@Zacqary
Copy link
Contributor Author

Zacqary commented Jan 28, 2022

Ran this 50x with the flaky test runner and it never failed: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/123

I think this is safe to merge

@Zacqary Zacqary removed the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 28, 2022
@Zacqary Zacqary merged commit 7e69c7d into elastic:main Jan 28, 2022
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
@Zacqary @awahab07
Reenable alert_create_flyout create alert test (elastic#123878)
f94e52f 
* Reenable alert_create_flyout create alert test

* Add rules tab reset to alert flyout test
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 123878 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 1, 2022
@chrisronline chrisronline added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.2.0 labels Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

@XavierM XavierM Awaiting requested review from XavierM

@JiaweiWu JiaweiWu Awaiting requested review from JiaweiWu

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.1.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
5 participants
@Zacqary @elasticmachine @kibana-ci @kibanamachine @chrisronline