[Lens] Duplicated datatable available as inspector data for Heatmap chart #123815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
reviewed
Jan 26, 2022
| @@ -143,7 +143,8 @@ export const heatmapFunction = (): HeatmapExpressionFunctionDefinition => ({ | |||
| }, | |||
| }, | |||
| fn(data, args, handlers) { | |||
| if (handlers?.inspectorAdapters?.tables) { | |||
| // as in lens we've already calling logDatatable for heatmap we shouldn't do it here | |||
| if (handlers?.inspectorAdapters?.tables && handlers?.getExecutionContext?.()?.type !== 'lens') { | |||
There was a problem hiding this comment.
honestly not sure that expression functions should know anything about their consumers.
💔 Build FailedFailed CI StepsMetrics [docs]Async chunks
Page load bundle
HistoryTo update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #123176
Summary
We shouldn't execute
logDatatablein heatmap_function if we open heatmap in lens because here we alredy had the function which executelogDatatable.