-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v46.1.0 #123652
Upgrade EUI to v46.1.0 #123652
Conversation
Pinging @elastic/eui-design (EUI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @thompsongl!
src/core/public/overlays/flyout/__snapshots__/flyout_service.test.tsx.snap
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally Security Threat Hunting changes related to EuiDataGrid. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VisEditors change LGTM, making value lookup for grid more robust. Code review only
* eui to 46.1.0 * use optimize build * dataGridWrapper -> euiDataGridBody * remove unused dep from bazel * use column-index and row-index attrs * datagrid test fixes * prevent duplicate global styles * snapshot updates * rendering_service test * update comment * clean up Co-authored-by: Kibana Machine <[email protected]>
Summary
[email protected]
⏩[email protected]
optimize/es
build for smaller footprintkbnUiSharedDeps-npmDll | 6.1MB | 4.8MB | -1.3MB
CoreContextProvider
to conditionally add global styles46.1.0
sun
glyph toEuiIcon
(#5548)EuiDescriptionList
oftype
inline (#5534)46.0.0
optimize
build as a lighter weight option more suited to production environments (#5527)lettering
glyph toEuiIcon
(#5525)euiCustomControlFocused
mixin to use$euiFocusRingColor
instead ofcurrentColor
(#5479)betaBadgeTooltipProps
toEuiKeyPadMenuItem
to extend the wrappingEuiToolTip
(#5541)globalStyles
prop toEuiProvider
to allow for global style customization (#5497)EuiGlobalStyles
component (#5497)Bug fixes
euiCustomControlFocused
mixin to use$euiFocusRingColor
instead ofcurrentColor
(#5479)EuiDataGrid
not fully scrolling cells into view (#5515)EuiKeyPadMenuItem
accessibility issue where there was a nested focusable element (#5541)Deprecations
data-gridcell-id
fromEuiDataGrid
in favor of 4 new and more flexible props -data-gridcell-column-id
,data-gridcell-column-index
,data-gridcell-row-index
, anddata-gridcell-visible-row-index
(#5515)Breaking changes
EuiKeyPadMenuItem
now wraps itself withEuiToolTip
whenbetaBadgeLabel
is supplied forcing top element style props to be passed viabetaBadgeTooltipProps
(#5541)45.0.0
EuiSelectableList
withisVirtualized
(#5521)EuiSelectableOption
withdata
(#5521)Bug fixes
EuiDataGrid
keyboard focus restoration (#5530)EuiDataGrid
's display toolbar control to update initial UI state when developergridStyle
orrowHeightsOptions
props are updated (#5525)Breaking changes
EuiSearchBar
to preserve phrases with leading and trailing spaces, instead of dropping surrounding whitespace (#5514)data-test-subj="dataGridWrapper"
fromEuiDataGrid
in favor ofdata-test-subj="euiDataGridBody"
(#5506)