Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v46.1.0 #123652

Merged
merged 23 commits into from
Jan 28, 2022
Merged

Upgrade EUI to v46.1.0 #123652

merged 23 commits into from
Jan 28, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jan 24, 2022

Summary

[email protected][email protected]

  • Uses the new optimize/es build for smaller footprint
    • No propTypes
    • Uses babel runtime-transform
    • kbnUiSharedDeps-npmDll | 6.1MB | 4.8MB | -1.3MB
  • Updates CoreContextProvider to conditionally add global styles

46.1.0

  • Added sun glyph to EuiIcon (#5548)
  • Updated styles in EuiDescriptionList of type inline (#5534)

46.0.0

  • [Beta] Added optimize build as a lighter weight option more suited to production environments (#5527)
  • Added lettering glyph to EuiIcon (#5525)
  • Updated the outline color in euiCustomControlFocused mixin to use $euiFocusRingColor instead of currentColor (#5479)
  • Added betaBadgeTooltipProps to EuiKeyPadMenuItem to extend the wrapping EuiToolTip (#5541)
  • Added globalStyles prop to EuiProvider to allow for global style customization (#5497)
  • Exported EuiGlobalStyles component (#5497)

Bug fixes

  • Updated the outline color in euiCustomControlFocused mixin to use $euiFocusRingColor instead of currentColor (#5479)
  • Fixed keyboard navigation in EuiDataGrid not fully scrolling cells into view (#5515)
  • Fixed EuiKeyPadMenuItem accessibility issue where there was a nested focusable element (#5541)

Deprecations

  • Deprecated data-gridcell-id from EuiDataGrid in favor of 4 new and more flexible props - data-gridcell-column-id, data-gridcell-column-index, data-gridcell-row-index, and data-gridcell-visible-row-index (#5515)

Breaking changes

  • EuiKeyPadMenuItem now wraps itself with EuiToolTip when betaBadgeLabel is supplied forcing top element style props to be passed via betaBadgeTooltipProps (#5541)

45.0.0

  • Added virtulized rendering option to EuiSelectableList with isVirtualized (#5521)
  • Added expanded option properties to EuiSelectableOption with data (#5521)

Bug fixes

  • Fixed multiple bugs with EuiDataGrid keyboard focus restoration (#5530)
  • Fixed EuiDataGrid's display toolbar control to update initial UI state when developer gridStyle or rowHeightsOptions props are updated (#5525)

Breaking changes

  • Changed EuiSearchBar to preserve phrases with leading and trailing spaces, instead of dropping surrounding whitespace (#5514)
  • Removed data-test-subj="dataGridWrapper" from EuiDataGrid in favor of data-test-subj="euiDataGridBody" (#5506)

@thompsongl thompsongl added release_note:skip Skip the PR/issue when compiling release notes EUI v8.1.0 labels Jan 24, 2022
@thompsongl thompsongl requested a review from spalger January 25, 2022 18:23
@thompsongl thompsongl marked this pull request as ready for review January 25, 2022 18:23
@thompsongl thompsongl requested review from a team as code owners January 25, 2022 18:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thompsongl!

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally Security Threat Hunting changes related to EuiDataGrid. LGTM!

@thompsongl thompsongl requested a review from afharo January 26, 2022 15:53
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kertal
Copy link
Member

kertal commented Jan 28, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1182 1179 -3
enterpriseSearch 1349 1346 -3
fileUpload 138 135 -3
lists 295 293 -2
maps 758 755 -3
securitySolution 2856 2854 -2
total -16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 40.6KB 40.6KB -3.0B
apm 2.8MB 2.8MB -678.0B
canvas 1.0MB 1.0MB -19.0B
cases 320.5KB 320.5KB -6.0B
console 376.9KB 376.9KB -6.0B
controls 379.6KB 379.5KB -16.0B
crossClusterReplication 163.2KB 163.2KB -6.0B
dashboard 273.5KB 273.5KB -13.0B
dataViewEditor 115.3KB 115.3KB -3.0B
dataViewFieldEditor 154.4KB 154.4KB -3.0B
dataViewManagement 117.5KB 117.4KB -19.0B
dataVisualizer 539.4KB 539.4KB -19.0B
discover 330.7KB 330.7KB -12.0B
enterpriseSearch 1.3MB 1.3MB -676.0B
expressionMetricVis 8.3KB 8.3KB -3.0B
expressions 44.1KB 44.1KB -3.0B
fileUpload 661.5KB 660.8KB -665.0B
fleet 644.6KB 644.5KB -16.0B
graph 448.4KB 448.4KB -6.0B
grokdebugger 59.1KB 59.1KB -3.0B
indexLifecycleManagement 148.4KB 148.4KB -3.0B
indexManagement 515.1KB 515.1KB -3.0B
infra 926.6KB 926.6KB -13.0B
ingestPipelines 452.4KB 452.4KB -3.0B
inputControlVis 77.8KB 77.8KB -22.0B
lens 1.0MB 1.0MB +12.0B
licenseManagement 61.2KB 61.2KB -3.0B
lists 140.6KB 140.2KB -408.0B
maps 2.5MB 2.5MB -675.0B
ml 3.5MB 3.5MB -21.0B
monitoring 445.5KB 445.5KB -3.0B
osquery 941.2KB 941.2KB -6.0B
presentationUtil 135.1KB 135.1KB -3.0B
remoteClusters 83.5KB 83.5KB -6.0B
rollup 129.0KB 129.0KB -6.0B
searchprofiler 159.2KB 159.2KB -3.0B
security 494.4KB 494.4KB -1.0B
securitySolution 4.6MB 4.6MB -399.0B
snapshotRestore 258.3KB 258.3KB -3.0B
stackAlerts 166.6KB 166.6KB -6.0B
timelines 226.6KB 226.5KB -13.0B
transform 365.8KB 365.7KB -19.0B
triggersActionsUi 674.9KB 674.9KB -24.0B
upgradeAssistant 166.5KB 166.5KB -16.0B
uptime 704.2KB 704.2KB -28.0B
visTypeTimelion 121.3KB 121.3KB -16.0B
visTypeTimeseries 448.0KB 448.0KB -6.0B
visTypeVega 2.0MB 2.0MB -16.0B
visTypeVislib 354.7KB 354.7KB -3.0B
visualizations 139.3KB 139.3KB -13.0B
watcher 272.6KB 272.6KB -3.0B
total -3.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 5.5KB 5.5KB -3.0B
alerting 37.7KB 37.7KB -3.0B
bfetch 7.4KB 7.4KB -3.0B
canvas 13.3KB 13.3KB -3.0B
cases 81.7KB 81.7KB -3.0B
charts 58.3KB 58.3KB -3.0B
cloud 6.5KB 6.5KB -3.0B
controls 19.4KB 19.4KB -3.0B
core 291.3KB 291.4KB +105.0B
customIntegrations 6.1KB 6.1KB -3.0B
dashboard 66.2KB 66.1KB -6.0B
dashboardEnhanced 14.2KB 14.2KB -6.0B
data 449.0KB 449.0KB -19.0B
dataEnhanced 9.4KB 9.4KB -6.0B
dataViewEditor 10.7KB 10.7KB -3.0B
dataViewFieldEditor 18.9KB 18.9KB -3.0B
dataViews 38.0KB 38.0KB -3.0B
dataVisualizer 16.5KB 16.5KB -3.0B
devTools 10.7KB 10.7KB -3.0B
discover 51.5KB 51.5KB -3.0B
discoverEnhanced 5.2KB 5.2KB -3.0B
embeddable 64.9KB 64.9KB -6.0B
embeddableEnhanced 6.5KB 6.5KB -3.0B
enterpriseSearch 15.8KB 15.8KB -3.0B
esUiShared 122.5KB 122.5KB -6.0B
expressionError 5.1KB 5.1KB -3.0B
expressionGauge 9.4KB 9.4KB -3.0B
expressionHeatmap 12.2KB 12.2KB -3.0B
expressionRepeatImage 6.3KB 6.3KB -3.0B
expressionRevealImage 6.3KB 6.3KB -3.0B
expressions 87.1KB 87.1KB -3.0B
expressionShape 14.0KB 14.0KB -3.0B
expressionTagcloud 7.5KB 7.5KB -3.0B
features 3.4KB 3.4KB -3.0B
fieldFormats 47.8KB 47.8KB -3.0B
fileUpload 7.2KB 7.2KB -3.0B
fleet 112.8KB 112.8KB -3.0B
globalSearch 8.1KB 8.1KB -3.0B
graph 7.1KB 7.1KB -3.0B
home 9.9KB 9.8KB -3.0B
indexLifecycleManagement 27.7KB 27.7KB -3.0B
indexManagement 27.1KB 27.1KB -3.0B
infra 90.5KB 90.5KB -6.0B
ingestPipelines 13.2KB 13.2KB -3.0B
inputControlVis 5.4KB 5.4KB -3.0B
inspector 22.3KB 22.3KB -3.0B
interactiveSetup 58.4KB 58.4KB -3.0B
kbnUiSharedDeps-css 591.5KB 591.6KB +38.0B
kbnUiSharedDeps-npmDll 6.1MB 4.8MB -1.3MB
kbnUiSharedDeps-srcJs 3.8MB 3.8MB -621.0B
kibanaReact 56.5KB 56.5KB -6.0B
kibanaUtils 67.5KB 67.5KB -6.0B
lens 41.3KB 41.3KB -6.0B
licenseManagement 10.2KB 10.2KB -3.0B
licensing 8.6KB 8.6KB -3.0B
lists 3.5KB 3.5KB -3.0B
logstash 14.3KB 14.3KB -3.0B
management 9.8KB 9.8KB -3.0B
maps 37.2KB 37.2KB -3.0B
mapsEms 5.7KB 5.7KB -3.0B
ml 38.9KB 38.9KB -3.0B
monitoring 23.6KB 23.6KB -6.0B
navigation 8.7KB 8.7KB -6.0B
newsfeed 9.7KB 9.7KB -3.0B
observability 83.9KB 83.9KB -19.0B
osquery 7.0KB 7.0KB -6.0B
presentationUtil 44.9KB 44.9KB -6.0B
reporting 38.6KB 38.6KB -6.0B
savedObjects 30.5KB 30.5KB -6.0B
savedObjectsManagement 15.4KB 15.4KB -3.0B
savedObjectsTagging 17.9KB 17.9KB -6.0B
savedObjectsTaggingOss 2.4KB 2.4KB -3.0B
screenshotMode 2.0KB 2.0KB -3.0B
screenshotting 2.0KB 2.0KB -3.0B
security 50.1KB 50.1KB -6.0B
securitySolution 245.7KB 245.7KB -19.0B
share 53.3KB 53.3KB -3.0B
sharedUX 3.7KB 3.7KB -3.0B
snapshotRestore 26.7KB 26.7KB -3.0B
spaces 20.3KB 20.3KB -6.0B
stackAlerts 11.9KB 11.9KB -3.0B
telemetry 24.7KB 24.7KB -3.0B
telemetryManagementSection 9.8KB 9.8KB -6.0B
timelines 136.5KB 136.5KB -6.0B
triggersActionsUi 53.9KB 53.9KB -3.0B
uiActions 19.3KB 19.3KB -3.0B
uiActionsEnhanced 22.1KB 22.1KB -6.0B
upgradeAssistant 18.7KB 18.7KB -3.0B
urlDrilldown 15.0KB 15.0KB -3.0B
urlForwarding 2.6KB 2.6KB -3.0B
usageCollection 5.0KB 5.0KB -3.0B
visDefaultEditor 19.4KB 19.4KB -3.0B
visTypeHeatmap 10.3KB 10.3KB -3.0B
visTypeMarkdown 7.0KB 7.0KB -6.0B
visTypeMetric 8.7KB 8.7KB -3.0B
visTypePie 7.9KB 7.9KB -3.0B
visTypeTagcloud 5.9KB 5.8KB -6.0B
visTypeTimelion 9.3KB 9.3KB -3.0B
visTypeTimeseries 15.5KB 15.5KB -3.0B
visTypeVega 32.7KB 32.7KB -3.0B
visTypeVislib 18.7KB 18.7KB -3.0B
visTypeXy 41.3KB 41.3KB -3.0B
visualizations 48.7KB 48.7KB -3.0B
watcher 13.6KB 13.6KB -3.0B
total -1.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VisEditors change LGTM, making value lookup for grid more robust. Code review only

@thompsongl thompsongl merged commit e84f370 into elastic:main Jan 28, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 28, 2022
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
* eui to 46.1.0

* use optimize build

* dataGridWrapper -> euiDataGridBody

* remove unused dep from bazel

* use column-index and row-index attrs

* datagrid test fixes

* prevent duplicate global styles

* snapshot updates

* rendering_service test

* update comment

* clean up

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants