Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parseAppUrl logic to handle app ids including other app ids #123594

Merged
merged 2 commits into from
Jan 25, 2022
Merged

fix parseAppUrl logic to handle app ids including other app ids #123594

merged 2 commits into from
Jan 25, 2022

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jan 24, 2022 •
edited
Loading

Summary

Fix #123449

Checklist

@pgayvallet pgayvallet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 v8.1.0 labels Jan 24, 2022
@pgayvallet pgayvallet marked this pull request as ready for review January 24, 2022 18:23
@pgayvallet pgayvallet requested a review from a team as a code owner January 24, 2022 18:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 291.1KB 291.3KB +140.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afharo
afharo approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I love that you added so many tests! 🧡

@pgayvallet pgayvallet added v7.17.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jan 25, 2022
@pgayvallet pgayvallet merged commit 531f545 into elastic:main Jan 25, 2022
@kibanamachine kibanamachine mentioned this pull request Jan 25, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 25, 2022
@pgayvallet @kibanamachine
fix parseAppUrl logic to handle app ids including other app ids (elas…
70e7e2b 
…tic#123594)

(cherry picked from commit 531f545)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 25, 2022
@pgayvallet @kibanamachine
fix parseAppUrl logic to handle app ids including other app ids (elas…
2949326 
…tic#123594)

(cherry picked from commit 531f545)
@kibanamachine kibanamachine mentioned this pull request Jan 25, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.0
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 25, 2022
@kibanamachine @pgayvallet
fix parseAppUrl logic to handle app ids including other app ids (#123594
e2548a5 
) (#123697)

(cherry picked from commit 531f545)

Co-authored-by: Pierre Gayvallet <[email protected]>
kibanamachine added a commit that referenced this pull request Jan 25, 2022
@kibanamachine @pgayvallet
fix parseAppUrl logic to handle app ids including other app ids (#123594
b37a52b 
) (#123698)

(cherry picked from commit 531f545)

Co-authored-by: Pierre Gayvallet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Incorrect parsing of app URL
5 participants
@pgayvallet @elasticmachine @kibana-ci @kibanamachine @afharo