Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ML URLs in doc link service #123328

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Update ML URLs in doc link service #123328

merged 2 commits into from
Jan 19, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 18, 2022

Summary

Relates to elastic/stack-docs#1739

The pages in the Machine Learning anomaly detection docs are changing, so we need to temporarily alter the URLs in the documentation link service. Otherwise, the following URLs break:

15:02:31 INFO:build_docs: Kibana [master]: src/core/public/doc_links/doc_links_service.ts contains broken links to:
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-bucket-span
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-calendars
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-cardinality
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-create-job
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-detectors
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-influencers
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-job-tips
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-model-memory-limits
15:02:31 INFO:build_docs: - en/machine-learning/master/ml-ad-finding-anomalies.html#ml-ad-rules

@lcawl lcawl added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes docs auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Jan 18, 2022
@lcawl lcawl requested a review from a team as a code owner January 18, 2022 23:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 291.2KB 291.1KB -156.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl enabled auto-merge (squash) January 19, 2022 01:50
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit de7d48a into elastic:main Jan 19, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 19, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 19, 2022
(cherry picked from commit de7d48a)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs :ml release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants