Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/ui-shared-deps-src #123313

Merged
merged 15 commits into from
Jan 20, 2022
Merged

chore(NA): splits types from code on @kbn/ui-shared-deps-src #123313

merged 15 commits into from
Jan 20, 2022

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 18, 2022

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 labels Jan 18, 2022
@mistic mistic requested a review from jbudz January 18, 2022 21:54
@mistic mistic force-pushed the split-types-from-code-on-kbn-ui-shared-deps-src-2 branch from 5f3d717 to 0468f50 Compare January 19, 2022 18:02
@elastic elastic deleted a comment from kibana-ci Jan 19, 2022
@mistic

This comment has been minimized.

Sign in to view
@mistic mistic marked this pull request as ready for review January 19, 2022 22:23
@mistic mistic requested review from a team as code owners January 19, 2022 22:23
@mistic mistic requested a review from parkiino January 19, 2022 22:23
cjcenizal
cjcenizal approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import path change in Dev Tools plugin LGTM.

@botelastic botelastic bot added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

FrankHassanabad
FrankHassanabad approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the test that is failing which should be skipped.

jbudz
jbudz approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

kertal
kertal approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataDiscovery.team changes LGTM, review, did not test

dej611
dej611 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only for @elastic/kibana-vis-editors

juliaElastic
juliaElastic approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet LGTM

darnautov
darnautov approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML, Transform and Data Visualizer changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-theme - 6 +6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 31.0KB 31.0KB +5.0B
charts 58.0KB 58.0KB +5.0B
dataViewEditor 10.7KB 10.7KB +5.0B
dataVisualizer 17.5KB 17.5KB +5.0B
devTools 10.7KB 10.7KB +5.0B
discover 51.5KB 51.5KB +5.0B
expressions 87.1KB 87.1KB +5.0B
fleet 112.8KB 112.8KB +5.0B
home 9.8KB 9.9KB +5.0B
interactiveSetup 58.4KB 58.4KB +5.0B
kbnUiSharedDeps-srcJs 3.8MB 3.8MB +5.0B
kibanaReact 56.5KB 56.5KB +5.0B
lens 41.3KB 41.3KB +5.0B
maps 37.1KB 37.1KB +5.0B
ml 38.9KB 38.9KB +5.0B
observability 79.5KB 79.5KB +5.0B
osquery 7.0KB 7.0KB +5.0B
security 50.1KB 50.1KB +5.0B
securitySolution 245.9KB 245.9KB +5.0B
timelines 136.4KB 136.4KB +5.0B
transform 14.0KB 14.0KB +5.0B
triggersActionsUi 53.9KB 53.9KB +5.0B
uptime 24.8KB 24.8KB +5.0B
visTypeVega 32.7KB 32.7KB +5.0B
visTypeVislib 18.7KB 18.7KB +5.0B
total +125.0B
Unknown metric groups

API count

id before after diff
@kbn/ui-theme - 7 +7

ESLint disabled line counts

id before after diff
@kbn/ui-shared-deps-src 4 2 -2
@kbn/ui-theme - 2 +2
total -0

Total ESLint disabled count

id before after diff
@kbn/ui-shared-deps-src 4 2 -2
@kbn/ui-theme - 2 +2
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Jan 20, 2022

This PR mainly touches the new layout for @kbn/ui-shared-deps-src package. As those changes require a relatively high maintenance on the PR I'm going ahead and merge it. Let me know if you have any other feedback for me to address.

@mistic mistic merged commit 356861d into elastic:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong left review comments

@kertal kertal kertal approved these changes

@dej611 dej611 dej611 approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@jbudz jbudz jbudz approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@darnautov darnautov darnautov approved these changes

@jportner jportner jportner approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Team label for Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.