Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Exceptions] Fix export toast text #123307

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jan 18, 2022

Summary

Fix bug on rule export where toaster reports export total as being rule objects + exceptions objects, but should just be rule objects total. Adds cypress test.

Before

Screen Shot 2022-01-11 at 8 50 26 AM

After

Screen Shot 2022-01-18 at 10 21 04 AM

Checklist

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +27.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero self-assigned this Jan 18, 2022
@yctercero yctercero added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team v8.0.0 labels Jan 18, 2022
@yctercero yctercero changed the title update export toast text bug [Security Solution][Exceptions] Fix export toast text Jan 18, 2022
@yctercero yctercero marked this pull request as ready for review January 18, 2022 22:55
@yctercero yctercero requested a review from a team as a code owner January 18, 2022 22:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed code review, LGTM! 👍

@yctercero yctercero added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 18, 2022
@yctercero yctercero merged commit b2c9f10 into elastic:main Jan 18, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 18, 2022
### Summary

Fix bug on rule export where toaster reports export total as being rule objects + exceptions objects, but should just be rule objects total. Adds cypress test.

(cherry picked from commit b2c9f10)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 19, 2022
…3326)

### Summary

Fix bug on rule export where toaster reports export total as being rule objects + exceptions objects, but should just be rule objects total. Adds cypress test.

(cherry picked from commit b2c9f10)

Co-authored-by: Yara Tercero <[email protected]>
@yctercero yctercero deleted the exceptions_import_count_fix branch January 19, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants