Fix issue with parsing out endpoint package policy. #123287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjhampton
added
auto-backport
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
pjhampton
added
release_note:skip
donaherc
reviewed
Jan 18, 2022
| @@ -145,11 +146,11 @@ export function createTelemetryEndpointTaskConfig(maxTelemetryBatch: number) { | |||
| packagePolicies | |||
| .map((pPolicy) => pPolicy as PolicyData) | |||
| .forEach((pPolicy) => { | |||
| if (pPolicy.inputs[0].config !== undefined) { | |||
| if (pPolicy.inputs[0]?.config !== undefined && pPolicy.inputs[0]?.config !== null) { | |||
There was a problem hiding this comment.
Gotcha, can see how this would error.
1 task
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @pjhampton |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 18, 2022
* Fix issue with parsing out endpoint package policy. * revert schedule. (cherry picked from commit 4d98af8)
💔 Some backports could not be created
How to fixRe-run the backport manually: Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
pjhampton
added a commit
that referenced
this pull request
Jan 19, 2022
kibanamachine
added a commit
that referenced
this pull request
Jan 20, 2022
* Fix issue with parsing out endpoint package policy. * revert schedule. (cherry picked from commit 4d98af8) Co-authored-by: Pete Hampton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We found an edge case on customer deployments where the telemetry was going dark due to a type error. While the root cause of why this is happening hasn't been established, the optional chaining and defaulting circumvents the reproducible type error.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers