-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs with the addition of filter editors #12321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added a minor comment for the operators but it's just a suggestion. The content and images look good.
docs/discover/field-filter.asciidoc
Outdated
particular value by selecting *is*, where a filter doesn't match a particular | ||
value by selecting *is not*, where a field is present (*exists*), or where a | ||
value for a field is within a range (*is between*). In addition, you can filter | ||
where a field *is one of* a particular list of values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this list be better represented as a table? Explicitly describing exactly how each operator works. It might be overkill, but at least we're not missing anything. There are 6 different operators. I added something similar here for the options available in Timelion
* Update docs with the addition of filter editors * Move operators into a table
* Update docs with the addition of filter editors * Move operators into a table
This PR updates the docs since the addition of filter editors.