[Fleet] Fix hide enrollment key tooltip #123188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
changed the title
| hasActions={true} | ||
| noItemsMessage={ | ||
| enrollmentAPIKeysRequest.isLoading && enrollmentAPIKeysRequest.isInitialRequest ? ( | ||
| (enrollmentAPIKeysRequest.isLoading && enrollmentAPIKeysRequest.isInitialRequest) || | ||
| (agentPoliciesRequest.isLoading && agentPoliciesRequest.isInitialRequest) ? ( |
There was a problem hiding this comment.
nit: this condition is used twice, could be extracted to a const
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 18, 2022
(cherry picked from commit 8ac8d69)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 18, 2022
(cherry picked from commit 8ac8d69)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 18, 2022
(cherry picked from commit 8ac8d69) Co-authored-by: Nicolas Chaulet <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 18, 2022
(cherry picked from commit 8ac8d69) Co-authored-by: Nicolas Chaulet <[email protected]>
|
Hi @nchaulet We have validated this fix on 7.17 BC5 on cloud-qa environment and found it fixed and working fine. Build details:
Screenshot: Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #120874
In the enrollment list page with multiple enrollment tokens when clicking on show enrollment token of multiple tokens we were keeping the "hide token" tooltip for all the previous tokens.
This was due to the fact that we were disabling the button and react is not triggering the blur event to hide the tooltip, that PR fix that by removing the button disablement.
Also fix the loading state to wait for the agent policies too otherwise the UI was blink and showing no enrollment tokens for an instant.
Before
After