[Security Solution] [Platform] Return additional errors during import rule + action migration process #123088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld, pre-8.0 action ids with the new migrated action SO ids. Ref: elastic#120975 (comment) for more information
dhurley14
added
auto-backport
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @dhurley14 |
yctercero
reviewed
Jan 18, 2022
|
|
||
| type PromiseFromStreams = ImportRulesSchemaDecoded | Error; | ||
|
|
||
| const createMockImportRule = async (rule: ReturnType<typeof getCreateRulesSchemaMock>) => { |
There was a problem hiding this comment.
Wish we could put mocks in packages to share around!
yctercero
reviewed
Jan 18, 2022
| const result = await swapActionIds(mockAction, soClient); | ||
| expect(result).toEqual(mockAction); | ||
| expect((result as Error).message).toEqual('failed to query'); |
There was a problem hiding this comment.
Not sure if maybe this is a preferred pattern for these? Might need to tweak it a bit, but something like:
Suggested change
| expect((result as Error).message).toEqual('failed to query'); | |
| await expect(() => swapActionIds(mockAction, soClient)).toThrowErrorMatchingInlineSnapshot('failed to query'); |
There was a problem hiding this comment.
Ah yeah I like that better. I'll update this!
yctercero
approved these changes
Jan 18, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 18, 2022
… rule + action migration process (elastic#123088) * exposes additional errors when ES failures occur during the swap of old, pre-8.0 action ids with the new migrated action SO ids. Ref: elastic#120975 (comment) for more information * fix test error Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 467d111)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 19, 2022
… rule + action migration process (#123088) (#123329) * exposes additional errors when ES failures occur during the swap of old, pre-8.0 action ids with the new migrated action SO ids. Ref: #120975 (comment) for more information * fix test error Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 467d111) Co-authored-by: Devin W. Hurley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
exposes additional errors when ES failures occur during the swap of old, pre-8.0 action ids with the new migrated action SO ids. Ref: #120975 (comment) for more information
Checklist
Delete any items that are not applicable to this PR.
For maintainers