Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): splits types from code on @kbn/ui-shared-deps-src #123074

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 14, 2022

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic requested a review from jbudz January 14, 2022 18:32
@mistic mistic added backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.1.0 labels Jan 14, 2022
@mistic

This comment has been minimized.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1178 1181 +3
charts 76 79 +3
dataViewEditor 86 89 +3
dataVisualizer 346 349 +3
devTools 17 20 +3
discover 360 363 +3
expressions 160 163 +3
fleet 556 559 +3
home 62 65 +3
interactiveSetup 50 53 +3
kibanaReact 301 304 +3
lens 711 714 +3
maps 757 760 +3
ml 1592 1595 +3
observability 348 351 +3
osquery 246 249 +3
security 401 404 +3
securitySolution 2844 2847 +3
timelines 283 286 +3
transform 290 293 +3
triggersActionsUi 332 335 +3
uptime 675 678 +3
visTypeVega 293 296 +3
visTypeVislib 184 187 +3
total +72

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-shared-deps-src 0 6 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +3.1KB
dataViewEditor 115.3KB 118.4KB +3.1KB
dataVisualizer 539.4KB 542.5KB +3.1KB
devTools 2.5KB 5.7KB +3.2KB
discover 330.8KB 333.9KB +3.2KB
expressions 44.1KB 47.2KB +3.1KB
fleet 644.1KB 647.2KB +3.1KB
home 77.4KB 80.6KB +3.1KB
kibanaReact 209.5KB 209.5KB -29.0B
lens 1.0MB 1.0MB +3.1KB
maps 2.5MB 2.5MB +3.1KB
ml 3.5MB 3.5MB +3.1KB
observability 357.8KB 364.2KB +6.3KB
osquery 939.1KB 942.2KB +3.1KB
security 494.4KB 497.6KB +3.2KB
securitySolution 4.6MB 4.6MB +3.1KB
timelines 224.9KB 225.0KB +16.0B
transform 360.3KB 363.4KB +3.1KB
triggersActionsUi 780.9KB 784.0KB +3.2KB
uptime 688.4KB 691.5KB +3.1KB
visTypeVega 2.0MB 2.0MB +3.2KB
visTypeVislib 354.7KB 357.8KB +3.1KB
total +65.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 31.0KB 30.9KB -49.0B
charts 58.0KB 61.1KB +3.1KB
dataViewEditor 10.7KB 10.7KB -49.0B
dataVisualizer 17.5KB 17.5KB -49.0B
devTools 10.7KB 10.6KB -49.0B
discover 51.5KB 51.4KB -49.0B
expressions 82.9KB 82.8KB -47.0B
fleet 112.7KB 112.7KB -49.0B
home 9.8KB 9.8KB -49.0B
interactiveSetup 58.4KB 61.5KB +3.1KB
kibanaReact 56.5KB 59.6KB +3.1KB
lens 41.3KB 41.2KB -49.0B
maps 37.1KB 37.1KB -49.0B
ml 38.5KB 38.5KB -49.0B
observability 79.3KB 79.2KB -49.0B
osquery 7.0KB 7.0KB -49.0B
security 50.1KB 50.1KB -49.0B
securitySolution 245.9KB 245.8KB -49.0B
timelines 136.7KB 139.7KB +3.1KB
transform 14.0KB 14.0KB -49.0B
triggersActionsUi 53.9KB 53.8KB -49.0B
uptime 24.8KB 24.7KB -49.0B
visTypeVega 32.7KB 32.7KB -49.0B
visTypeVislib 18.7KB 18.6KB -49.0B
total +11.4KB
Unknown metric groups

API count

id before after diff
@kbn/ui-shared-deps-src 0 7 +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants