[Uptime] Overview link to Exploratory View should not filter by monitor #122907

justinkambic · 2022-01-13T04:17:00Z

Summary

The Overview page should no longer filter the Exploratory View by monitor name when the link is clicked.

Testing this PR

Follow the steps in the linked issue. When running this branch you should see that the exploratory view link that the page generates does not contain a monitor-specific filter on the overview page. This monitor filtering should work on other pages.

Index some data with Heartbeat.
Go to the Overview page in Uptime.
Drill into a monitor.
Return to the Overview page without reloading the app.
Click the Explore Data link.
Ensure that the Exploratory View is not filtered down to a single monitor.

Repeat these same steps with the certs view. Start on the overview page, drill in, then go to certs and link to exp. view.

Ensure that when clicking from the detail page of a monitor, the exp. view is still filtered by monitor.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2022-01-13T04:17:03Z

Pinging @elastic/uptime (Team:uptime)

justinkambic · 2022-01-13T17:26:00Z

~~Note to reviewers, don't review this yet. We've had some offline discussion, some changes are needed.~~

This is now ready for review.

justinkambic · 2022-01-14T14:42:43Z

@elasticmachine merge upstream

shahzad31 · 2022-01-14T16:49:35Z

x-pack/plugins/uptime/public/components/common/header/action_menu_content.tsx

+              /*
+               * The second condition exists because we don't want to link users to an
+               * exploratory view that is filtered by a specific monitor when they're on
+               * the Uptime Overview page.
+               *
+               * This condition is intended to allow monitor filtering on all other pages.
+               */


Comment is helpful but seems unnecessary :)
I think code is self explanatory, No?

I was on the fence about it. I told myself if the reviewer mentioned it I'd delete it 😉

Done baa460e.

…rview page.

…er on exploratory view link.

kibana-ci · 2022-01-14T19:39:25Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`uptime`	688.3KB	688.3KB	+64.0B

History

💚 Build #17529 succeeded 7b7b521d37b37de3a42bcb55b0d4e339dfba2919
💛 Build #17403 was flaky 4bec0d12dbc78dd8f7c0d63445f4b20a0496b6b1
💚 Build #17160 succeeded f4eeef4152856a645d86475cb4ea7cfee0de3cb8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

kibanamachine · 2022-01-14T19:45:01Z

💔 All backports failed

Status	Branch	Result
❌	8.0	Backport failed because of merge conflicts You might need to backport the following PRs to 8.0: - Revert "[Uptime] redirect Uptime tutorials to the Elastic Synthetics Integration (#115229) (#115470)" (#118986) - [Uptime] redirect Uptime tutorials to the Elastic Synthetics Integration (#115229)
❌	7.17	Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 122907

Questions ?

Please refer to the Backport tool documentation

…or (elastic#122907) * Modify Exploratory View link to prevent filtering by monitor from Overview page. * Modify route match so only detail page will include monitor name filter on exploratory view link. * Remove unnecessary comment. (cherry picked from commit 939a642)

…or (#122907) (#123262) * Modify Exploratory View link to prevent filtering by monitor from Overview page. * Modify route match so only detail page will include monitor name filter on exploratory view link. * Remove unnecessary comment. (cherry picked from commit 939a642)

kibanamachine · 2022-01-18T19:46:19Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-01-19T19:56:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

…y monitor (#122907) (#123268) * [Uptime] Overview link to Exploratory View should not filter by monitor (#122907) * Modify Exploratory View link to prevent filtering by monitor from Overview page. * Modify route match so only detail page will include monitor name filter on exploratory view link. * Remove unnecessary comment. (cherry picked from commit 939a642) * Fix `cherry-pick` error. * Fix merge errors. Co-authored-by: Kibana Machine <[email protected]>

justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0 v7.17.0 labels Jan 13, 2022

justinkambic requested a review from a team as a code owner January 13, 2022 04:17

justinkambic self-assigned this Jan 13, 2022

justinkambic added the release_note:fix label Jan 13, 2022

justinkambic force-pushed the 121348/explore-data-button-on-uptime-overview-filters-by-a-specific-monitor branch from f4eeef4 to 4bec0d1 Compare January 13, 2022 22:09

shahzad31 approved these changes Jan 14, 2022

View reviewed changes

justinkambic added 3 commits January 14, 2022 13:17

Modify Exploratory View link to prevent filtering by monitor from Ove…

cdc630a

…rview page.

Modify route match so only detail page will include monitor name filt…

d076641

…er on exploratory view link.

Remove unnecessary comment.

baa460e

justinkambic force-pushed the 121348/explore-data-button-on-uptime-overview-filters-by-a-specific-monitor branch from 7b7b521 to baa460e Compare January 14, 2022 18:17

justinkambic added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 14, 2022

justinkambic enabled auto-merge (squash) January 14, 2022 18:18

justinkambic merged commit 939a642 into elastic:main Jan 14, 2022

justinkambic mentioned this pull request Jan 18, 2022

[8.0] [Uptime] Overview link to Exploratory View should not filter by monitor (#122907) #123262

Merged

justinkambic mentioned this pull request Jan 18, 2022

[7.17] [Uptime] Overview link to Exploratory View should not filter by monitor (#122907) #123268

Merged

justinkambic deleted the 121348/explore-data-button-on-uptime-overview-filters-by-a-specific-monitor branch January 18, 2022 17:36

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 18, 2022

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Overview link to Exploratory View should not filter by monitor #122907

[Uptime] Overview link to Exploratory View should not filter by monitor #122907

justinkambic commented Jan 13, 2022 •

edited

Loading

elasticmachine commented Jan 13, 2022

justinkambic commented Jan 13, 2022 •

edited

Loading

justinkambic commented Jan 14, 2022

shahzad31 Jan 14, 2022

justinkambic Jan 14, 2022

justinkambic Jan 14, 2022

kibana-ci commented Jan 14, 2022

kibanamachine commented Jan 14, 2022

kibanamachine commented Jan 18, 2022

kibanamachine commented Jan 19, 2022

[Uptime] Overview link to Exploratory View should not filter by monitor #122907

[Uptime] Overview link to Exploratory View should not filter by monitor #122907

Conversation

justinkambic commented Jan 13, 2022 • edited Loading

Summary

Testing this PR

Checklist

Risk Matrix

For maintainers

elasticmachine commented Jan 13, 2022

justinkambic commented Jan 13, 2022 • edited Loading

justinkambic commented Jan 14, 2022

shahzad31 Jan 14, 2022

Choose a reason for hiding this comment

justinkambic Jan 14, 2022

Choose a reason for hiding this comment

justinkambic Jan 14, 2022

Choose a reason for hiding this comment

kibana-ci commented Jan 14, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

History

kibanamachine commented Jan 14, 2022

💔 All backports failed

How to fix

Questions ?

kibanamachine commented Jan 18, 2022

kibanamachine commented Jan 19, 2022

justinkambic commented Jan 13, 2022 •

edited

Loading

justinkambic commented Jan 13, 2022 •

edited

Loading