Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix enrollment api key role descriptor application name #122798

Conversation

nchaulet
Copy link
Member

Summary

Resolve elastic/beats#29811

In elastic/elasticsearch#82049 Elasticsearch started to validate the role descriptor inside an API key our application name was invalid so it started to throw and block the creation of enrollment API key.

That PR fix that by providing a valid application name.

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.17.0 labels Jan 12, 2022
@nchaulet nchaulet self-assigned this Jan 12, 2022
@nchaulet nchaulet changed the title [Fleet] Fix enrollment api key application name [Fleet] Fix enrollment api key role descriptor application name Jan 12, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet marked this pull request as ready for review January 12, 2022 17:14
@nchaulet nchaulet requested a review from a team as a code owner January 12, 2022 17:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small enough fix to just approve outright. Thanks for the quick turn around here 🚀

@nchaulet nchaulet merged commit c180aac into elastic:main Jan 12, 2022
@nchaulet nchaulet deleted the fix-beats-29811-application-name-should-be-valid branch January 12, 2022 18:07
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 12, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 12, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 12, 2022
(cherry picked from commit c180aac)

Co-authored-by: Nicolas Chaulet <[email protected]>
kibanamachine added a commit that referenced this pull request Jan 12, 2022
(cherry picked from commit c180aac)

Co-authored-by: Nicolas Chaulet <[email protected]>
@ruflin
Copy link
Contributor

ruflin commented Jan 14, 2022

@nchaulet Glad to see we also got this into 7.x. This removes a potential problem where an older version of Kibana is talking to a newer version of Elasticsearch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.17.0 v8.0.0 v8.1.0
Projects
None yet
6 participants