[Connectors] Checking for undefined config and secrets during connector validation #122696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
added
Feature:Actions/Framework
|
Pinging @elastic/response-ops (Team:ResponseOps) |
mikecote
approved these changes
Jan 12, 2022
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
ymao1
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 19, 2022
…or validation (elastic#122696) * Checking for undefined config and secrets during connector validation * Adding functional tests Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit d19a2f3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 19, 2022
…or validation (#122696) (#123369) * Checking for undefined config and secrets during connector validation * Adding functional tests Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit d19a2f3) Co-authored-by: ymao1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #122346
Summary
With this PR, we added validation of connector config and secrets together. This validation was only added to the email connector. We've found that in cases where the connector
secretsfield is undefined, this will lead to a null accessor error (Cannot read properties of undefined) when executing connector action (either via the test connector UI or during actual action execution. Thesecretsvalue can become undefined due to decryption errors during migration.To Verify
secrets must be definedinstead ofCannot read properties of undefinedChecklist