Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update platform security modules (main) #122475

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 6, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node-forge ^0.10.10 -> ^1.0.0 age adoption passing confidence
node-forge ^0.10.0 -> ^1.1.0 age adoption passing confidence

Release Notes

digitalbazaar/forge

v1.1.0

Compare Source

Fixed
  • [x509]: Correctly compute certificate issuer and subject hashes to match
    behavior of openssl.
  • [pem]: Accept certificate requests with "NEW" in the label. "BEGIN NEW
    CERTIFICATE REQUEST" handled as "BEGIN CERTIFICATE REQUEST".

v1.0.0

Compare Source

Notes
  • 1.0.0!
  • This project is over a decade old! Time for a 1.0.0 release.
  • The URL related changes may expose bugs in some of the networking related
    code (unrelated to the much wider used cryptography code). The automated and
    manual test coverage for this code is weak at best. Issues or patches to
    update the code or tests would be appreciated.
Removed
  • SECURITY, BREAKING: Remove forge.debug API. The API has the
    potential for prototype pollution. This API was only briefly used by the
    maintainers for internal project debug purposes and was never intended to be
    used with untrusted user inputs. This API was not documented or advertised
    and is being removed rather than fixed.
  • SECURITY, BREAKING: Remove forge.util.parseUrl() (and
    forge.http.parseUrl alias) and use the WHATWG URL
    Standard
    . URL is supported by modern browers
    and modern Node.js. This change is needed to address URL parsing security
    issues. If forge.util.parseUrl() is used directly or through forge.xhr or
    forge.http APIs, and support is needed for environments without URL
    support, then a polyfill must be used.
  • BREAKING: Remove forge.task API. This API was never used, documented,
    or advertised by the maintainers. If anyone was using this API and wishes to
    continue development it in other project, please let the maintainers know.
    Due to use in the test suite, a modified version is located in
    tests/support/.
  • BREAKING: Remove forge.util.makeLink, forge.util.makeRequest,
    forge.util.parseFragment, forge.util.getQueryVariables. Replace with
    URL, URLSearchParams, and custom code as needed.
Changed
  • BREAKING: Increase supported Node.js version to 6.13.0 for URL support.
  • BREAKING: Renamed master branch to main.
  • BREAKING: Release process updated to use tooling that prefixes versions
    with v. Other tools, scripts, or scanners may need to adapt.
  • BREAKING: Remove docs related to Bower and
    forge-dist. Install using
    another method.
Added
  • OIDs for surname, title, and givenName.
Fixed
  • BREAKING: OID 2.5.4.5 name fixed from serialName to serialNumber.
    Depending on how applications used this id to name association it could cause
    compatibility issues.

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Jan 6, 2022
@renovate renovate bot requested a review from a team January 6, 2022 22:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@renovate renovate bot force-pushed the renovate/main-platform-security-modules branch from 32bd75d to d3dba45 Compare January 7, 2022 06:16
@renovate renovate bot changed the title Update platform security modules to v1 (main) Update platform security modules (main) Jan 7, 2022
@jportner
Copy link
Contributor

jportner commented Jan 7, 2022

@elasticmachine run elasticsearch-ci/docs

@jportner
Copy link
Contributor

jportner commented Jan 7, 2022

Unfortunately we have two transitive dependencies of node-forge that will be stuck on v0.10.0:

yarn why node-forge
yarn why v1.22.10
[1/4] 🤔  Why do we have the module "node-forge"...?
[2/4] 🚚  Initialising dependency graph...
...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "node-forge"
info Reasons this module exists
   - Specified in "dependencies"
   - Hoisted from "@elastic#request-crypto#node-jose#node-forge"
   - Hoisted from "webpack-dev-server#selfsigned#node-forge"
info Disk size without dependencies: "1.77MB"

However, we only use these on the server side so we won't increase bundle sizes by changing our direct dependency to a different version.

The changes mostly revolve around removing unused APIs and changing URL parsing (which affects networking-related code). We don't use node-forge for that, we rely on it for parsing certificates and for cryptography, so I think our existing test coverage is sufficient for this upgrade.

EDIT: I checked both https://github.com/cisco/node-jose and https://github.com/jfromaniello/selfsigned, neither of them use any of the node-forge methods that have been changed/removed in this release. I'm confident it is safe to use a yarn dependency resolution to upgrade those as well.

@jportner jportner enabled auto-merge (squash) January 7, 2022 16:39
@jportner jportner disabled auto-merge January 7, 2022 16:39
@jportner jportner enabled auto-merge (squash) January 7, 2022 16:40
@jportner jportner disabled auto-merge January 7, 2022 17:00
@jportner jportner removed the v7.16.3 label Jan 7, 2022
@jportner jportner enabled auto-merge (squash) January 7, 2022 17:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner
Copy link
Contributor

jportner commented Jan 7, 2022

@elasticmachine run elasticsearch-ci/docs

@jportner jportner merged commit 526367c into main Jan 7, 2022
@jportner jportner deleted the renovate/main-platform-security-modules branch January 7, 2022 19:04
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.0:
- Update Github Action for backport (#122479)
7.17 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 122475

Questions ?

Please refer to the Backport tool documentation

jportner pushed a commit to jportner/kibana that referenced this pull request Jan 7, 2022
Co-authored-by: Renovate Bot <[email protected]>
(cherry picked from commit 526367c)

# Conflicts:
#	package.json
#	yarn.lock
jportner pushed a commit to jportner/kibana that referenced this pull request Jan 7, 2022
Co-authored-by: Renovate Bot <[email protected]>
(cherry picked from commit 526367c)

# Conflicts:
#	package.json
#	yarn.lock
@jportner
Copy link
Contributor

jportner commented Jan 7, 2022

💚 All backports created successfully

Status Branch Result
8.0
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jportner added a commit that referenced this pull request Jan 7, 2022
Co-authored-by: Renovate Bot <[email protected]>
(cherry picked from commit 526367c)

# Conflicts:
#	package.json
#	yarn.lock

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jportner added a commit that referenced this pull request Jan 7, 2022
Co-authored-by: Renovate Bot <[email protected]>
(cherry picked from commit 526367c)

# Conflicts:
#	package.json
#	yarn.lock

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants