Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Assign and remove Event Filters by policy based on user license #122434

Merged

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Jan 6, 2022

Summary

Hides remove event filter and assign event filter to policy button for < platinum license.

platinum
image
image
image

gold
image
image
image

Checklist

Delete any items that are not applicable to this PR.

@ashokaditya ashokaditya self-assigned this Jan 6, 2022
@ashokaditya ashokaditya added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0 labels Jan 6, 2022
@ashokaditya ashokaditya force-pushed the task/olm_downgrade_exp_event_filters-2032 branch 4 times, most recently from d44424a to 20ddaf5 Compare January 10, 2022 08:54
@ashokaditya ashokaditya force-pushed the task/olm_downgrade_exp_event_filters-2032 branch from 20ddaf5 to dfe4526 Compare January 10, 2022 09:17
@ashokaditya ashokaditya marked this pull request as ready for review January 10, 2022 11:29
@ashokaditya ashokaditya requested a review from a team as a code owner January 10, 2022 11:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

// }),
// [navigateCallback]
// );
const navigateCallback = usePolicyDetailsNavigateCallback();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for uncomment this! I totally forgot it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks back to you. 👏 good thing you'd placed these lines already. I'd to uncomment it and it worked out of the box. 😬

@ashokaditya ashokaditya force-pushed the task/olm_downgrade_exp_event_filters-2032 branch from e393087 to 6584231 Compare January 10, 2022 12:38
Copy link
Contributor

@parkiino parkiino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@ashokaditya
Copy link
Member Author

@elasticmachine merge upstream

@ashokaditya ashokaditya enabled auto-merge (squash) January 11, 2022 16:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +534.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit 33af3fc into elastic:main Jan 11, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 11, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 122434

Questions ?

Please refer to the Backport tool documentation

@ashokaditya ashokaditya deleted the task/olm_downgrade_exp_event_filters-2032 branch January 11, 2022 19:20
@ashokaditya ashokaditya removed the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants